fix: create all resources in the operator namespace #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leelavg
reviewed
Dec 31, 2021
| @@ -57,6 +57,10 @@ spec: | |||
| valueFrom: | |||
| fieldRef: | |||
| fieldPath: metadata.namespace | |||
| - name: POD_NAMESPACE | |||
There was a problem hiding this comment.
- any scenario where
POD_NAMESPACEwill be different toWATCH_NAMESPACE, if not we can use the same i guess?
There was a problem hiding this comment.
I thought that this may be something we might want to support in the future but I agree that this will be the same for now. I will remove WATCH_NAMESPACE.
Adds the POD_NAMESPACE env var to the operator container spec. This is the namespace the operator pod is running in and all resources will be created in this namespace. Removes the WATCH_NAMESPACE env var as the operator will now watch only its own namespace. Signed-off-by: N Balachandran <nibalach@redhat.com>
The operator creates all resources in its own namespace instead of the LVMCluster resource namespace. Signed-off-by: N Balachandran <nibalach@redhat.com>
This updates the tests to include the new Namespace field in LVMClusterReconciler. Signed-off-by: N Balachandran <nibalach@redhat.com>
Updates the CSV with the changes to the manager. Signed-off-by: N Balachandran <nibalach@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: leelavg, nbalacha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix creates all resources in the operator namespace instead of the LVMCluster namespace. This is required if, in future, the operator will be extended to watch all namespaces.