-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-29065: Reconcile topolvm node volumes #570
OCPBUGS-29065: Reconcile topolvm node volumes #570
Conversation
Signed-off-by: Suleyman Akbas <sakbas@redhat.com>
@suleymanakbas91: This pull request references Jira Issue OCPBUGS-29065, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-4.15 #570 +/- ##
================================================
+ Coverage 81.45% 81.85% +0.40%
================================================
Files 24 24
Lines 1790 1835 +45
================================================
+ Hits 1458 1502 +44
Misses 225 225
- Partials 107 108 +1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jakobmoellerdev, suleymanakbas91 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@suleymanakbas91: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@suleymanakbas91: Jira Issue OCPBUGS-29065: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-29065 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
This PR fixes the 4.14 to 4.15 upgrade of TopoLVM Node. It currently fails as we introduced a new "metrics-cert" volume for TopoLVM Node in 4.15 and LVMS didn't reconcile the volumes.