Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-30346: chore: update feature annotations for lvms #585

Merged

Conversation

jakobmoellerdev
Copy link
Contributor

No description provided.

@openshift-ci-robot
Copy link

@jakobmoellerdev: This pull request explicitly references no jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 6, 2024
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 6, 2024
@suleymanakbas91
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot requested review from jeff-roche and jerpeter1 March 6, 2024 17:59
Copy link
Contributor

openshift-ci bot commented Mar 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2024
@jakobmoellerdev jakobmoellerdev changed the title NO-JIRA: chore: update feature annotations for lvms OCPBUGS-30346: chore: update feature annotations for lvms Mar 6, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Mar 6, 2024
@openshift-ci-robot
Copy link

@jakobmoellerdev: This pull request references Jira Issue OCPBUGS-30346, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @radeore

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from radeore March 6, 2024 18:03
@jakobmoellerdev
Copy link
Contributor Author

/override ci/prow/snyk-deps

Copy link
Contributor

openshift-ci bot commented Mar 6, 2024

@jakobmoellerdev: Overrode contexts on behalf of jakobmoellerdev: ci/prow/snyk-deps

In response to this:

/override ci/prow/snyk-deps

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jakobmoellerdev
Copy link
Contributor Author

/override ci/prow/precommit-check

Copy link
Contributor

openshift-ci bot commented Mar 6, 2024

@jakobmoellerdev: Overrode contexts on behalf of jakobmoellerdev: ci/prow/precommit-check

In response to this:

/override ci/prow/precommit-check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.46%. Comparing base (7666e83) to head (55c4c63).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #585      +/-   ##
==========================================
- Coverage   77.56%   77.46%   -0.11%     
==========================================
  Files          27       27              
  Lines        1948     1948              
==========================================
- Hits         1511     1509       -2     
- Misses        321      322       +1     
- Partials      116      117       +1     

see 1 file with indirect coverage changes

Signed-off-by: Jakob Möller <jmoller@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2024
@suleymanakbas91
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2024
@jakobmoellerdev
Copy link
Contributor Author

/override ci/prow/snyk-deps

Copy link
Contributor

openshift-ci bot commented Mar 6, 2024

@jakobmoellerdev: Overrode contexts on behalf of jakobmoellerdev: ci/prow/snyk-deps

In response to this:

/override ci/prow/snyk-deps

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

openshift-ci bot commented Mar 6, 2024

@jakobmoellerdev: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit f13ee72 into openshift:main Mar 6, 2024
9 checks passed
@openshift-ci-robot
Copy link

@jakobmoellerdev: Jira Issue OCPBUGS-30346: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-30346 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants