OCPBUGS-32268: chore: remove image based FBC and replace with dynamic generation

[jakobmoellerdev]

This changes the File Based Catalog to use the local bundle directory instead of the bundle image thanks to a new Feature in OPM that allows us to directly embed the bundle objects.

This is important for 2 reasons:

1. Now we do not have to push the bundle somewhere in order to build a catalog, making the deploy-with-olm much better/faster
2. Previously for backports the runs on the backports for the precommit might fail because the bundle:latest image would point to the main branch and there would be differences in the bundle between the backported version and the main branch, causing the verify-catalog.sh step to fail

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jakobmoellerdev]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.56%. Comparing base (7770551) to head (5730a67).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #609   +/-   ##
=======================================
  Coverage   77.56%   77.56%           
=======================================
  Files          27       27           
  Lines        1952     1952           
=======================================
  Hits         1514     1514           
  Misses        320      320           
  Partials      118      118           

[jakobmoellerdev]

/override ci/prow/snyk-deps

[jakobmoellerdev]

/override ci/prow/precommit-check

[openshift-ci]

@jakobmoellerdev: Overrode contexts on behalf of jakobmoellerdev: ci/prow/snyk-deps

In response to this:

/override ci/prow/snyk-deps

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@jakobmoellerdev: Overrode contexts on behalf of jakobmoellerdev: ci/prow/precommit-check

In response to this:

/override ci/prow/precommit-check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jeff-roche]

/lgtm

[jakobmoellerdev]

/hold

[jakobmoellerdev]

/hold

[jakobmoellerdev]

/unhold

[jakobmoellerdev]

/override ci/prow/precommit-check

[jakobmoellerdev]

/override ci/prow/snyk-deps

[openshift-ci]

@jakobmoellerdev: Overrode contexts on behalf of jakobmoellerdev: ci/prow/precommit-check

In response to this:

/override ci/prow/precommit-check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@jakobmoellerdev: Overrode contexts on behalf of jakobmoellerdev: ci/prow/snyk-deps

In response to this:

/override ci/prow/snyk-deps

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@jakobmoellerdev: This pull request explicitly references no jira issue.

In response to this:

This changes the File Based Catalog to use the local bundle directory instead of the bundle image thanks to a new Feature in OPM that allows us to directly embed the bundle objects.

This is important for 2 reasons:

1. Now we do not have to push the bundle somewhere in order to build a catalog, making the deploy-with-olm much better/faster
2. Previously for backports the runs on the backports for the precommit might fail because the bundle:latest image would point to the main branch and there would be differences in the bundle between the backported version and the main branch, causing the verify-catalog.sh step to fail

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@jakobmoellerdev: This pull request references Jira Issue OCPBUGS-32268, which is invalid:

• expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This changes the File Based Catalog to use the local bundle directory instead of the bundle image thanks to a new Feature in OPM that allows us to directly embed the bundle objects.

This is important for 2 reasons:

1. Now we do not have to push the bundle somewhere in order to build a catalog, making the deploy-with-olm much better/faster
2. Previously for backports the runs on the backports for the precommit might fail because the bundle:latest image would point to the main branch and there would be differences in the bundle between the backported version and the main branch, causing the verify-catalog.sh step to fail

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jakobmoellerdev]

/jira refresh

[openshift-ci-robot]

@jakobmoellerdev: This pull request references Jira Issue OCPBUGS-32268, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @radeore

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[suleymanakbas91]

/lgtm

[jakobmoellerdev]

/override ci/prow/precommit-check

[openshift-ci]

@jakobmoellerdev: Overrode contexts on behalf of jakobmoellerdev: ci/prow/precommit-check

In response to this:

/override ci/prow/precommit-check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@jakobmoellerdev: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@jakobmoellerdev: Jira Issue OCPBUGS-32268: All pull requests linked via external trackers have merged:

• openshift/lvm-operator#609

Jira Issue OCPBUGS-32268 has been moved to the MODIFIED state.

In response to this:

This changes the File Based Catalog to use the local bundle directory instead of the bundle image thanks to a new Feature in OPM that allows us to directly embed the bundle objects.

This is important for 2 reasons:

1. Now we do not have to push the bundle somewhere in order to build a catalog, making the deploy-with-olm much better/faster
2. Previously for backports the runs on the backports for the precommit might fail because the bundle:latest image would point to the main branch and there would be differences in the bundle between the backported version and the main branch, causing the verify-catalog.sh step to fail

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.