OCPBUGS-32954: OCPBUGS-32753: Remove LVMVolumeGroupNodeStatus CRs when LVMCluster CR is removed

[suleymanakbas91]

No description provided.

[openshift-ci-robot]

@suleymanakbas91: This pull request references Jira Issue OCPBUGS-32954, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @radeore

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jakobmoellerdev]

In general LGTM, but its missing unit and integration tests

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 77.61%. Comparing base (2cc9880) to head (0045d70).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #617      +/-   ##
==========================================
- Coverage   77.75%   77.61%   -0.15%     
==========================================
  Files          27       27              
  Lines        1960     1961       +1     
==========================================
- Hits         1524     1522       -2     
- Misses        319      320       +1     
- Partials      117      119       +2     

Files	Coverage Δ
internal/controllers/lvmcluster/controller.go	63.90% <71.42%> (-1.30%)	⬇️

[jakobmoellerdev]

/lgtm

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 7ea9e75 and 2 for PR HEAD 28b9a0c in total

[suleymanakbas91]

/retest

[suleymanakbas91]

/retest

[suleymanakbas91]

/hold

[suleymanakbas91]

/unhold

[openshift-ci]

@suleymanakbas91: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[jakobmoellerdev]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev, suleymanakbas91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jakobmoellerdev,suleymanakbas91]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@suleymanakbas91: Jira Issue OCPBUGS-32954: All pull requests linked via external trackers have merged:

• openshift/lvm-operator#617

Jira Issue OCPBUGS-32954 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[suleymanakbas91]

/cherry-pick release-4.15

[openshift-cherrypick-robot]

@suleymanakbas91: #617 failed to apply on top of branch "release-4.15":

Applying: feat: remove LVMVolumeGroupNodeStatus CRs as well when LVMCluster CR is removed
Using index info to reconstruct a base tree...
M	internal/controllers/lvmcluster/controller.go
M	internal/controllers/lvmcluster/controller_integration_test.go
Falling back to patching base and 3-way merge...
Auto-merging internal/controllers/lvmcluster/controller_integration_test.go
Auto-merging internal/controllers/lvmcluster/controller.go
CONFLICT (content): Merge conflict in internal/controllers/lvmcluster/controller.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 feat: remove LVMVolumeGroupNodeStatus CRs as well when LVMCluster CR is removed
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.