Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSDOCS-10556: Update descriptions for the API fields #627

Merged
merged 1 commit into from
May 15, 2024

Conversation

suleymanakbas91
Copy link
Contributor

@suleymanakbas91 suleymanakbas91 commented May 14, 2024

This PR updates the API descriptions, which are also shown in the console UI, to ensure that they are consistent with the descriptions in the product documentation.

Signed-off-by: Suleyman Akbas <sakbas@redhat.com>
@suleymanakbas91 suleymanakbas91 changed the title docs: update descriptions for the API fields OSDOCS-10556: Update descriptions for the API fields May 14, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 14, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 14, 2024

@suleymanakbas91: This pull request references OSDOCS-10556 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 14, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.51%. Comparing base (fd47a86) to head (1e05ef3).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #627   +/-   ##
=======================================
  Coverage   77.51%   77.51%           
=======================================
  Files          27       27           
  Lines        1961     1961           
=======================================
  Hits         1520     1520           
  Misses        321      321           
  Partials      120      120           
Files Coverage Δ
api/v1alpha1/lvmcluster_types.go 100.00% <ø> (ø)

@openshift-ci openshift-ci bot requested review from eggfoobar and jeff-roche May 14, 2024 14:21
Copy link
Contributor

openshift-ci bot commented May 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: suleymanakbas91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 14, 2024

@suleymanakbas91: This pull request references OSDOCS-10556 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

This PR updates the API descriptions, which are also shown in the console UI, to ensure that they are consistent with the descriptions in the product documentation.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented May 14, 2024

@suleymanakbas91: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sr1kar99
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 0816722 into openshift:main May 15, 2024
9 checks passed
@suleymanakbas91 suleymanakbas91 deleted the api-doc-updates branch May 15, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants