Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-34227: feat: chunk size policy #633

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

jakobmoellerdev
Copy link
Contributor

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 11, 2024
Copy link
Contributor

openshift-ci bot commented Jun 11, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@jakobmoellerdev
Copy link
Contributor Author

/test all

@jakobmoellerdev jakobmoellerdev changed the title feat: chunk size policy OCPBUGS-34227: feat: chunk size policy Jun 11, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 11, 2024
@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 11, 2024
@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jun 11, 2024
@openshift-ci-robot
Copy link

@jakobmoellerdev: This pull request references Jira Issue OCPBUGS-34227, which is invalid:

  • expected the bug to target the "4.17.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Jun 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2024
Signed-off-by: Jakob Möller <jmoller@redhat.com>
@jakobmoellerdev
Copy link
Contributor Author

/test all

@jakobmoellerdev jakobmoellerdev marked this pull request as ready for review June 12, 2024 14:29
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 12, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 86.36364% with 6 lines in your changes missing coverage. Please review.

Project coverage is 60.72%. Comparing base (a0a2217) to head (2dd9e9a).
Report is 12 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #633       +/-   ##
===========================================
- Coverage   77.97%   60.72%   -17.26%     
===========================================
  Files          28       54       +26     
  Lines        2016     4448     +2432     
===========================================
+ Hits         1572     2701     +1129     
- Misses        335     1497     +1162     
- Partials      109      250      +141     
Files Coverage Δ
api/v1alpha1/lvmcluster_types.go 100.00% <ø> (ø)
internal/controllers/vgmanager/controller.go 78.35% <100.00%> (+5.48%) ⬆️
internal/controllers/vgmanager/lvm/lvm.go 99.03% <100.00%> (ø)
api/v1alpha1/lvmcluster_webhook.go 88.16% <96.15%> (+4.44%) ⬆️
...ternal/controllers/vgmanager/lvm/mocks/mock_lvm.go 35.86% <44.44%> (ø)

... and 27 files with indirect coverage changes

Copy link
Contributor

openshift-ci bot commented Jun 12, 2024

@jakobmoellerdev: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@suleymanakbas91
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 12, 2024
@jakobmoellerdev
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 13, 2024
@openshift-ci-robot
Copy link

@jakobmoellerdev: This pull request references Jira Issue OCPBUGS-34227, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @radeore

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from radeore June 13, 2024 08:02
@openshift-merge-bot openshift-merge-bot bot merged commit 284c13e into openshift:main Jun 13, 2024
9 checks passed
@openshift-ci-robot
Copy link

@jakobmoellerdev: Jira Issue OCPBUGS-34227: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-34227 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jakobmoellerdev
Copy link
Contributor Author

/cherry-pick release-4.16

@openshift-cherrypick-robot

@jakobmoellerdev: #633 failed to apply on top of branch "release-4.16":

Applying: feat: chunk size policy
Using index info to reconstruct a base tree...
M	api/v1alpha1/lvmcluster_types.go
M	api/v1alpha1/zz_generated.deepcopy.go
M	bundle/manifests/lvm.topolvm.io_lvmclusters.yaml
M	catalog/lvms-operator/v0.0.1.yaml
M	config/crd/bases/lvm.topolvm.io_lvmclusters.yaml
Falling back to patching base and 3-way merge...
Auto-merging config/crd/bases/lvm.topolvm.io_lvmclusters.yaml
Auto-merging catalog/lvms-operator/v0.0.1.yaml
CONFLICT (content): Merge conflict in catalog/lvms-operator/v0.0.1.yaml
Auto-merging bundle/manifests/lvm.topolvm.io_lvmclusters.yaml
Auto-merging api/v1alpha1/zz_generated.deepcopy.go
Auto-merging api/v1alpha1/lvmcluster_types.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 feat: chunk size policy
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants