Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: more changes to the CRD status #79

Merged
merged 2 commits into from
Jan 18, 2022
Merged

feat: more changes to the CRD status #79

merged 2 commits into from
Jan 18, 2022

Conversation

nbalacha
Copy link
Contributor

The LVMCluster and LVMVoluemGroupNodeStatus will now include information about the devices being used by the configured volumegroups.

The LVMCluster.Status has been modified to include the list of devices
used by each volumegroup.

Signed-off-by: N Balachandran <nibalach@redhat.com>
Copy link
Contributor

@leelavg leelavg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2022
Copy link
Contributor

@jmolmo jmolmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we may need a device status in the future

@@ -158,6 +158,12 @@ func (r *VGReconciler) reconcile(ctx context.Context, req ctrl.Request) (ctrl.Re
}

_, found := deviceClassMap[volumeGroup.Name]
if found {
volGrpHostInfo, err := GetVolumeGroup(r.executor, volumeGroup.Name)
if err == nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not handle errors?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@@ -217,6 +223,11 @@ func (r *VGReconciler) reconcile(ctx context.Context, req ctrl.Request) (ctrl.Re
}
}

volGrpHostInfo, err := GetVolumeGroup(r.executor, volumeGroup.Name)
if err == nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not handle errors?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2022
The LVMVolumeGroupNodeStatus and LVMCluster status will now include
information about the devices being used by the volumegroups.

Signed-off-by: N Balachandran <nibalach@redhat.com>
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 18, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jmolmo, leelavg, nbalacha, sp98

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nbalacha nbalacha merged commit ee6b6bb into openshift:main Jan 18, 2022
@nbalacha nbalacha deleted the status-2 branch March 22, 2022 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants