Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use operator image for init containers #94

Merged
merged 2 commits into from
Jan 28, 2022
Merged

fix: use operator image for init containers #94

merged 2 commits into from
Jan 28, 2022

Conversation

leelavg
Copy link
Contributor

@leelavg leelavg commented Jan 28, 2022

  • move function to get running pod image into common controller utils
  • use operator image from running pod for init containers in topolvm
    controller and topolvm node

Signed-off-by: Leela Venkaiah G lgangava@redhat.com

controllers/utils.go Outdated Show resolved Hide resolved
- move function to get running pod image into common controller utils
- use operator image from running pod for init containers in topolvm
  controller and topolvm node

Signed-off-by: Leela Venkaiah G <lgangava@redhat.com>
- get the operator image name from reconciler struct

Signed-off-by: Leela Venkaiah G <lgangava@redhat.com>
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2022
@nbalacha
Copy link
Contributor

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 28, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: leelavg, nbalacha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nbalacha nbalacha merged commit d38b431 into openshift:main Jan 28, 2022
@nbalacha
Copy link
Contributor

/cherry-pick release-4.10

@openshift-cherrypick-robot

@nbalacha: new pull request created: #95

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nbalacha
Copy link
Contributor

/cherry-pick -x release-4.10

@openshift-cherrypick-robot

@nbalacha: cannot checkout -x release-4.10: error checking out -x release-4.10: exit status 129. output: error: unknown switch `x'
usage: git checkout []
or: git checkout [] [] -- ...

-b <branch>           create and checkout a new branch
-B <branch>           create/reset and checkout a branch
-l                    create reflog for new branch
--guess               second guess 'git checkout <no-such-branch>' (default)
--overlay             use overlay mode (default)
-q, --quiet           suppress progress reporting
--recurse-submodules[=<checkout>]
                      control recursive updating of submodules
--progress            force progress reporting
-m, --merge           perform a 3-way merge with the new branch
--conflict <style>    conflict style (merge or diff3)
-d, --detach          detach HEAD at named commit
-t, --track           set upstream info for new branch
-f, --force           force checkout (throw away local modifications)
--orphan <new-branch>
                      new unparented branch
--overwrite-ignore    update ignored files (default)
--ignore-other-worktrees
                      do not check if another worktree is holding the given ref
-2, --ours            checkout our version for unmerged files
-3, --theirs          checkout their version for unmerged files
-p, --patch           select hunks interactively
--ignore-skip-worktree-bits
                      do not limit pathspecs to sparse entries only
--pathspec-from-file <file>
                      read pathspec from file
--pathspec-file-nul   with --pathspec-from-file, pathspec elements are separated with NUL character

In response to this:

/cherry-pick -x release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants