Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-44732: Support for br-ex with DHCP and static DNS #4724

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mkowalski
Copy link
Contributor

Currently the only supported combination is either DHCP or static IP on the default gateway interface. This leads to the scenario when IP address from DHCP and static DNS address is not working (the custom DNS is just ignored).

With this change we allow to have DNS configured manually no matter where the IP address of the interface comes from.

In principle this should be done using k-nmstate operator and its global DNS configuration, but it seems there are scenarios where we want this functionality already at installation time.

Closes: OCPBUGS-44732

Currently the only supported combination is either DHCP or static IP on
the default gateway interface. This leads to the scenario when IP
address from DHCP and static DNS address is not working (the custom DNS
is just ignored).

With this change we allow to have DNS configured manually no matter
where the IP address of the interface comes from.

In principle this should be done using k-nmstate operator and its
global DNS configuration, but it seems there are scenarios where we want
this functionality already at installation time.

Closes: OCPBUGS-44732
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 29, 2024
@openshift-ci-robot
Copy link
Contributor

@mkowalski: This pull request references Jira Issue OCPBUGS-44732, which is invalid:

  • expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Currently the only supported combination is either DHCP or static IP on the default gateway interface. This leads to the scenario when IP address from DHCP and static DNS address is not working (the custom DNS is just ignored).

With this change we allow to have DNS configured manually no matter where the IP address of the interface comes from.

In principle this should be done using k-nmstate operator and its global DNS configuration, but it seems there are scenarios where we want this functionality already at installation time.

Closes: OCPBUGS-44732

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mkowalski
Copy link
Contributor Author

/jira refresh

@openshift-ci openshift-ci bot requested review from djoshy and LorbusChris November 29, 2024 14:44
@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 29, 2024
@openshift-ci-robot
Copy link
Contributor

@mkowalski: This pull request references Jira Issue OCPBUGS-44732, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @rbbratta

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from rbbratta November 29, 2024 14:44
Copy link
Contributor

openshift-ci bot commented Nov 29, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mkowalski
Once this PR has been reviewed and has the lgtm label, please assign lorbuschris for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Nov 29, 2024

@mkowalski: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-op 77acb06 link true /test e2e-gcp-op
ci/prow/e2e-aws-ovn 77acb06 link true /test e2e-aws-ovn
ci/prow/e2e-gcp-op-techpreview 77acb06 link false /test e2e-gcp-op-techpreview
ci/prow/e2e-hypershift 77acb06 link true /test e2e-hypershift
ci/prow/e2e-aws-ovn-upgrade 77acb06 link true /test e2e-aws-ovn-upgrade
ci/prow/e2e-azure-ovn-upgrade-out-of-change 77acb06 link false /test e2e-azure-ovn-upgrade-out-of-change
ci/prow/e2e-aws-ovn-upgrade-out-of-change 77acb06 link false /test e2e-aws-ovn-upgrade-out-of-change
ci/prow/e2e-gcp-op-single-node 77acb06 link true /test e2e-gcp-op-single-node
ci/prow/okd-scos-e2e-aws-ovn 77acb06 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-vsphere-ovn-zones 77acb06 link false /test e2e-vsphere-ovn-zones

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants