Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] MCO-1457: Reintroduce MCS CA rotation #4735

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

djoshy
Copy link
Contributor

@djoshy djoshy commented Dec 5, 2024

This PR re-applies the work done in #4669, which was reverted in #4713. We should only land this after openshift/installer#9309

How to verify:
In addition to passing existing e2es and verification done in #4669 , agent installations should succeed. The recently added test in the MCO repo which tests agent workflows(ci/prow/e2e-agent-compact-ipv4) should give us a good signal on this.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 5, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 5, 2024

@djoshy: This pull request references MCO-1457 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

This PR does the following:

How to verify:
In addition to passing existing e2es and verification done in #4669 , agent installations should succeed. The recently added test in the MCO repo which tests agent workflows(ci/prow/e2e-agent-compact-ipv4) should give us a good signal on this.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 5, 2024
Copy link
Contributor

openshift-ci bot commented Dec 5, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@djoshy djoshy force-pushed the reintroduce-mcs-ca-sync branch from 2b5c52e to 8c3e3a6 Compare December 5, 2024 15:05
Copy link
Contributor

openshift-ci bot commented Dec 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 11, 2024

@djoshy: This pull request references MCO-1457 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

This PR re-applies the work done in #4669, which was reverted in #4713. We should only land this after openshift/installer#9309

How to verify:
In addition to passing existing e2es and verification done in #4669 , agent installations should succeed. The recently added test in the MCO repo which tests agent workflows(ci/prow/e2e-agent-compact-ipv4) should give us a good signal on this.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@djoshy
Copy link
Contributor Author

djoshy commented Dec 11, 2024

/testwith openshift/machine-config-operator/master/e2e-agent-compact-ipv4 #4735 openshift/installer#9309

@djoshy djoshy changed the title [WIP] MCO-1457: Reintroduce MCS CA rotation with bootstrap support [WIP] MCO-1457: Reintroduce MCS CA rotation Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants