-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] MCO-1457: Reintroduce MCS CA rotation #4735
base: master
Are you sure you want to change the base?
Conversation
This re-applies the work in openshift#4669
@djoshy: This pull request references MCO-1457 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Skipping CI for Draft Pull Request. |
2b5c52e
to
8c3e3a6
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: djoshy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@djoshy: This pull request references MCO-1457 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/testwith openshift/machine-config-operator/master/e2e-agent-compact-ipv4 #4735 openshift/installer#9309 |
This PR re-applies the work done in #4669, which was reverted in #4713. We should only land this after openshift/installer#9309
How to verify:
In addition to passing existing e2es and verification done in #4669 , agent installations should succeed. The recently added test in the MCO repo which tests agent workflows(
ci/prow/e2e-agent-compact-ipv4
) should give us a good signal on this.