Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not check package version on non-master/node #3887

Merged
merged 1 commit into from
Apr 13, 2017
Merged

Do not check package version on non-master/node #3887

merged 1 commit into from
Apr 13, 2017

Conversation

rhcarvalho
Copy link
Contributor

Fixes #3594.

@rhcarvalho rhcarvalho requested a review from codificat April 10, 2017 12:05
@rhcarvalho rhcarvalho force-pushed the pkg-version-only-master-or-node branch from 656932a to 534418d Compare April 10, 2017 14:46
@rhcarvalho
Copy link
Contributor Author

@codificat, I've updated the implementation to use is_active to skip the check when appropriate. PTAL.

@rhcarvalho rhcarvalho mentioned this pull request Apr 10, 2017
Merged
codificat
codificat approved these changes Apr 10, 2017
View reviewed changes
Copy link
Member

@codificat codificat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch implementing is_active

@rhcarvalho
Copy link
Contributor Author

aos-ci-test

@rhcarvalho
Copy link
Contributor Author

[merge]

@openshift-bot
Copy link

[test]ing while waiting on the merge queue

@openshift-bot
Copy link

error: aos-ci-jenkins/OS_3.6_containerized for 534418d (logs)

@openshift-bot
Copy link

success: "aos-ci-jenkins/OS_3.5_NOT_containerized, aos-ci-jenkins/OS_3.5_NOT_containerized_e2e_tests" for 534418d (logs)

@openshift-bot
Copy link

success: "aos-ci-jenkins/OS_3.6_NOT_containerized, aos-ci-jenkins/OS_3.6_NOT_containerized_e2e_tests" for 534418d (logs)

@openshift-bot
Copy link

success: "aos-ci-jenkins/OS_3.5_containerized, aos-ci-jenkins/OS_3.5_containerized_e2e_tests" for 534418d (logs)

@rhcarvalho
Copy link
Contributor Author

aos-ci-test

@rhcarvalho
Copy link
Contributor Author

continuous-integration/openshift-jenkins/test — Failed

build/temp.linux-x86_64-2.7/build
    creating build/temp.linux-x86_64-2.7/build/temp.linux-x86_64-2.7
    gcc -pthread -fno-strict-aliasing -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -D_GNU_SOURCE -fPIC -fwrapv -DNDEBUG -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -D_GNU_SOURCE -fPIC -fwrapv -fPIC -I/usr/include/python2.7 -c build/temp.linux-x86_64-2.7/_openssl.c -o build/temp.linux-x86_64-2.7/build/temp.linux-x86_64-2.7/_openssl.o
    build/temp.linux-x86_64-2.7/_openssl.c:12:24: fatal error: pyconfig.h: No such file or directory
     #  include <pyconfig.h>
                            ^
    compilation terminated.
    error: command 'gcc' failed with exit status 1

https://ci.openshift.redhat.com/jenkins/job/test_pull_request_openshift_ansible_tox/8/console

@stevekuznetsov @sdodson missing dependencies to compile Python modules?

@openshift-bot
Copy link

error: aos-ci-jenkins/OS_3.6_containerized for 534418d (logs)

@openshift-bot
Copy link

success: "aos-ci-jenkins/OS_3.5_NOT_containerized, aos-ci-jenkins/OS_3.5_NOT_containerized_e2e_tests" for 534418d (logs)

@openshift-bot
Copy link

success: "aos-ci-jenkins/OS_3.6_NOT_containerized, aos-ci-jenkins/OS_3.6_NOT_containerized_e2e_tests" for 534418d (logs)

@openshift-bot
Copy link

success: "aos-ci-jenkins/OS_3.5_containerized, aos-ci-jenkins/OS_3.5_containerized_e2e_tests" for 534418d (logs)

@stevekuznetsov
Copy link
Contributor

@rhcarvalho fixed it this morning, those install instructions in the README for tox should also say to install the cryptography dependencies ;)

@stevekuznetsov
Copy link
Contributor

re[merge]

@rhcarvalho
Copy link
Contributor Author

I can't really tell what failed... https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_openshift_ansible/199/

[merge] again

@sdodson
Copy link
Member

sdodson commented Apr 12, 2017

flake openshift/origin#10162
[merge]

@openshift-bot
Copy link

openshift-bot commented Apr 12, 2017 •
edited
Loading

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_openshift_ansible/28/) (Base Commit: 8515131)

@rhcarvalho
Copy link
Contributor Author

The unit test failures were caused by the way we instantiate action plugins in tests, something that manifested itself only in Ansible 2.3 and fixed in #3919.

[test]

@openshift-bot
Copy link

Evaluated for openshift ansible test up to 534418d

@openshift-bot
Copy link

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_openshift_ansible/28/) (Base Commit: 8515131)

@rhcarvalho
Copy link
Contributor Author

[merge]

@openshift-bot
Copy link

Evaluated for openshift ansible merge up to 534418d

@openshift-bot openshift-bot merged commit 54f32cf into openshift:master Apr 13, 2017
@rhcarvalho rhcarvalho deleted the pkg-version-only-master-or-node branch April 13, 2017 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codificat codificat codificat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rhcarvalho @openshift-bot @stevekuznetsov @sdodson @codificat