Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding pods/logs to manageiq role #4673

Merged
merged 1 commit into from
Aug 4, 2017

Conversation

enoodle
Copy link
Contributor

@enoodle enoodle commented Jul 4, 2017

This will allow manageiq to read the logs from elasticsearch in the logging project.

Based on the changes from fabric8io/openshift-elasticsearch-plugin#73

@enoodle
Copy link
Contributor Author

enoodle commented Jul 4, 2017

cc @jcantrill @richm

@openshift-bot
Copy link

Can one of the admins verify this patch?
I understand the following commands:

  • bot, add author to whitelist
  • bot, test pull request
  • bot, test pull request once

1 similar comment
@openshift-bot
Copy link

Can one of the admins verify this patch?
I understand the following commands:

  • bot, add author to whitelist
  • bot, test pull request
  • bot, test pull request once

@jcantrill
Copy link
Contributor

aos-ci-test

@openshift-bot
Copy link

error: aos-ci-jenkins/OS_3.6_containerized for a9ecf43 (logs)

@@ -24,6 +24,12 @@
- apiGroups:
- ""
resources:
- pods/logs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's called pods/log

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@openshift-bot
Copy link

success: "aos-ci-jenkins/OS_3.6_NOT_containerized, aos-ci-jenkins/OS_3.6_NOT_containerized_e2e_tests" for a9ecf43 (logs)

@openshift-bot
Copy link

success: "aos-ci-jenkins/OS_3.5_NOT_containerized, aos-ci-jenkins/OS_3.5_NOT_containerized_e2e_tests" for a9ecf43 (logs)

@openshift-bot
Copy link

success: "aos-ci-jenkins/OS_3.5_containerized, aos-ci-jenkins/OS_3.5_containerized_e2e_tests" for a9ecf43 (logs)

@simon3z
Copy link
Contributor

simon3z commented Jul 17, 2017

@jcantrill is this ready for merge?

@jcantrill
Copy link
Contributor

[merge]

@enoodle
Copy link
Contributor Author

enoodle commented Jul 17, 2017

I found a problem - we didn't actually assigned that cluster-role correctly before. I guess something else enabled us to access pod/proxy anyway (maybe the cluster-reader role?)

The tests are failing for:

No package matching 'atomic-openshift-docker-excluder-3.6.134*' found available, installed or updated

which doesn't tell me much, I don't think it is connected to this PR.

@enoodle enoodle force-pushed the allow_manageiq_to_read_logs branch from a9ecf43 to 7f8ef2e Compare July 17, 2017 18:55
@enoodle
Copy link
Contributor Author

enoodle commented Jul 18, 2017

@jcantrill @richm Can you please take another look?

@jcantrill
Copy link
Contributor

@enoodle best I can tell LGTM

@simon3z
Copy link
Contributor

simon3z commented Jul 18, 2017

@enoodle best I can tell LGTM

@jcantrill who should merge this?

@jcantrill
Copy link
Contributor

jcantrill commented Jul 19, 2017 via email

@enoodle
Copy link
Contributor Author

enoodle commented Jul 25, 2017

[test]

@enoodle
Copy link
Contributor Author

enoodle commented Jul 25, 2017

@jcantrill I am really not sure why this PR keeps failing, The logs failing dont seem to be connected to these changes. Can you please take a look?

@jcantrill
Copy link
Contributor

aos-ci-test

@enoodle enoodle force-pushed the allow_manageiq_to_read_logs branch from 7f8ef2e to 3079d2b Compare July 25, 2017 16:57
@enoodle
Copy link
Contributor Author

enoodle commented Jul 25, 2017

@jcantrill I have rebased this on master, maybe this would help, can you initiate the test again?

aos-ci-test

@openshift-bot
Copy link

success: "aos-ci-jenkins/OS_3.6_NOT_containerized, aos-ci-jenkins/OS_3.6_NOT_containerized_e2e_tests" for 7f8ef2e (logs)

@openshift-bot
Copy link

success: "aos-ci-jenkins/OS_3.6_containerized, aos-ci-jenkins/OS_3.6_containerized_e2e_tests" for 7f8ef2e (logs)

@enoodle
Copy link
Contributor Author

enoodle commented Jul 30, 2017

@sdodson @jcantrill This seems to be passing tests now, can you see if it is possible to merge?

@jcantrill
Copy link
Contributor

aos-ci-test

@openshift-bot
Copy link

error: aos-ci-jenkins/OS_3.6_NOT_containerized for 3079d2b (logs)

@openshift-bot
Copy link

error: aos-ci-jenkins/OS_3.6_containerized for 3079d2b (logs)

@enoodle enoodle force-pushed the allow_manageiq_to_read_logs branch from 3079d2b to 1d1c631 Compare August 1, 2017 07:59
@enoodle
Copy link
Contributor Author

enoodle commented Aug 1, 2017

aos-ci-test

@enoodle
Copy link
Contributor Author

enoodle commented Aug 1, 2017

[test]

@enoodle
Copy link
Contributor Author

enoodle commented Aug 2, 2017

@jcantrill Can we try to merge again?

@sdodson
Copy link
Member

sdodson commented Aug 2, 2017

aos-ci-test

@openshift-bot
Copy link

success: "aos-ci-jenkins/OS_3.6_NOT_containerized, aos-ci-jenkins/OS_3.6_NOT_containerized_e2e_tests" for 1d1c631 (logs)

@openshift-bot
Copy link

success: "aos-ci-jenkins/OS_3.6_containerized, aos-ci-jenkins/OS_3.6_containerized_e2e_tests" for 1d1c631 (logs)

@enoodle
Copy link
Contributor Author

enoodle commented Aug 2, 2017

@sdodson maybe we can merge this now? I am not sure what this state means..

@sdodson
Copy link
Member

sdodson commented Aug 2, 2017

[merge]

@openshift-bot
Copy link

Evaluated for openshift ansible merge up to 1d1c631

@openshift-bot
Copy link

OpenShift Ansible Action Required: Please contact #openshift-ansible to have this pull request manually reviewed and tested

@openshift-bot
Copy link

continuous-integration/openshift-jenkins/merge FAILURE (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_openshift_ansible/784/) (Base Commit: 1765ce2) (PR Branch Commit: 1d1c631) (Extended Tests: blocker)

This will allow manageiq to read the logs from elasticsearch
in the logging project.

Also, adding role to correct user and as clusterrole
@enoodle
Copy link
Contributor Author

enoodle commented Aug 3, 2017

Jenkins doesn't like this PR. I will rebase again...

@enoodle enoodle force-pushed the allow_manageiq_to_read_logs branch from 1d1c631 to 497c01b Compare August 3, 2017 08:41
@enoodle
Copy link
Contributor Author

enoodle commented Aug 3, 2017

aos-ci-test

@sdodson sdodson merged commit 145c90c into openshift:master Aug 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants