[1.5 backport] set the proper label of /var/lib/etcd directory #4690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giuseppe
approved these changes
Jul 6, 2017
|
Saw your comment on the BZ and I reply to myself: no since in 1.4 we were using etcdctl from the host. |
ashcrow
approved these changes
Jul 6, 2017
|
[test] |
|
@ingvagabund @ashcrow, is it worth creating a card to track upstream changes required to make the official ansible module work? We should at least file a bug or track this. |
kwoodson
approved these changes
Jul 6, 2017
|
@kwoodson I like that. Us using the commands directly is tech debt. @ingvagabund please create a card in the backlog for this. |
|
aos-ci-test |
|
[test] |
ingvagabund
force-pushed
the
set-label-of-var-lib-etcd-1.5
branch
from
7c045ef to
58de9fc
Compare
|
aos-ci-test |
|
Evaluated for openshift ansible test up to 58de9fc |
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_openshift_ansible/329/) (Base Commit: aa1f0a0) (PR Branch Commit: 58de9fc) |
|
flake openshift/origin#10162 |
|
aos-ci-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cause there is no guarantee the /var/lib/etcd will keep its
svirt_sandbox_file_tlabel between installation and upgrade.The /var/lib/etcd will have incorrect
var_lib_tlabel until theetcd_containerservice is restarted. Once restarted, the directory is correctly re-labeled.