Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating how storage type is determined, adding bool filter in opensh… #4844

Merged
merged 1 commit into from
Jul 26, 2017

Conversation

ewolinetz
Copy link
Contributor

…ift_logging_elasticsearch

Addresses https://bugzilla.redhat.com/show_bug.cgi?id=1463081
Will require 3.6 backport

Copy link
Contributor

@jcantrill jcantrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though that long if statement for setting the storage type is not clear IMO. drawback of the framework i guess.

@ewolinetz
Copy link
Contributor Author

aos-ci-test

@openshift-bot
Copy link

success: "aos-ci-jenkins/OS_3.6_NOT_containerized, aos-ci-jenkins/OS_3.6_NOT_containerized_e2e_tests" for a795717 (logs)

@openshift-bot
Copy link

success: "aos-ci-jenkins/OS_3.6_containerized, aos-ci-jenkins/OS_3.6_containerized_e2e_tests" for a795717 (logs)

@ewolinetz
Copy link
Contributor Author

[merge]

@openshift-bot
Copy link

Evaluated for openshift ansible merge up to a795717

@openshift-bot
Copy link

[test]ing while waiting on the merge queue

@ewolinetz
Copy link
Contributor Author

test flaked on openshift/origin#15356
re[test]

@openshift-bot
Copy link

Evaluated for openshift ansible test up to a795717

@openshift-bot
Copy link

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_openshift_ansible/364/) (Base Commit: d1ee0ee) (PR Branch Commit: a795717)

@openshift-bot
Copy link

continuous-integration/openshift-jenkins/merge FAILURE (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_openshift_ansible/738/) (Base Commit: d1ee0ee) (PR Branch Commit: a795717)

@sdodson sdodson merged commit 0f6cf67 into openshift:master Jul 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants