Master image pull fails #5024
Master image pull fails #5024
Conversation
When using openshift_use_system_containers=True it fails as : system_images_registry is not available in a dict Signed-off-by: jkaurredhat <jkaur@redhat.com>
|
If this isn't a backport we need to make the change on master first. |
|
Please specify system_images_registry, we need fully specified image names for system containers. We need to document this |
|
It looks like @ingvagabund made a similar change in master in b7aea29. |
|
This looks like the backport from the master of #4789. |
|
@ingvagabund @jkaurredhat where you folks not setting |
|
It needs to be set only when |
|
aos-ci-test |
|
Ahh ok, it's for CI more than actual usage. In that case I'm OK with this. |
|
@jkaurredhat the |
|
@ingvagabund agreed. I think as @giuseppe pointed out this is more of a lack of proper documentation letting users know they have to set the variable. |
|
FWIW I'll try to throw some minor documentation together in master to help keep this from happening in the future. |
|
We could also set proper default values, docker hub for origin and access redhat.com for ose. What do you think? |
|
😕 |
system_images_registry is required for system container installations but no example was put in the inventory files. This change adds a note saying the variable is required when using system containers and provides an example. Ref: openshift#5024
|
@ashcrow in this case it will just be needed to reflect what we already do when setting the docker additional registries. Users will still be able to override it if required |
system_images_registry is required for system container installations but no example was put in the inventory files. This change adds a note saying the variable is required when using system containers and provides an example. Ref: openshift#5024
When using
openshift_use_system_containers=True
it fails as :
system_images_registry is not available in a dict
Signed-off-by: jkaurredhat jkaur@redhat.com