-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin consolidate #6469
Plugin consolidate #6469
Conversation
1871a49
to
5630457
Compare
5630457
to
b67f3ea
Compare
b67f3ea
to
4e80c21
Compare
All the symlinks for filter_plugins, lookup_plugins and library should be removed. You could also consolidate the callback from the installer_checkpoint role. The README.md would just need to be moved/renamed and the references to that role updated. I don't know how much value adding Moving the openshift_quick_installer callback probably broke the quick installer. |
It gives us and other users an approximate idea of where this filter lives. |
I plan on more consolidation in a follow up. |
4e80c21
to
f839b9e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look fine. I've run a 3.7 install and an upgrade to 3.8 successfully. I'm withholding the lgtm label because I'm not certain of the specfile changes or the impact to the quick installer.
f839b9e
to
7bf621c
Compare
7bf621c
to
84027d0
Compare
This commit relocates filter_plugings to lib_utils, changes the namespacing to prevent unintended use of older versions that may be present in filter_plugins/ directory on existing installs. Add lib_utils to meta depends for roles Also consolidate some plugins into lib_utils from various other areas. Update rpm spec, obsolete plugin rpms.
84027d0
to
801779e
Compare
Specfile changes look good, I've verified the upgrade path works as expected from old to new packages. |
/test all [submit-queue is verifying that this PR is safe to merge] |
I'll rebase #4264 to get rid of all the remaining subpackages once this merges. |
@michaelgugino: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Install phase of those tests all completed. Looking to assess how soon the e2e tests will be fixed and may go ahead and merge without any e2e tests. |
openshift/openshift-ansible#6469 relocated rpm_q.py to a different directory.
openshift/openshift-ansible#6469 relocated rpm_q.py to a different directory.
openshift/openshift-ansible#6469 relocated rpm_q.py to a different directory.
This commit relocates filter_plugings to lib_utils,
changes the namespacing to prevent unintended use of
older versions that may be present in filter_plugins/
directory on existing installs.
Add lib_utils to meta depends for roles
Also consolidate some plugins into lib_utils from
various other areas.
Update rpm spec, obsolete plugin rpms.