Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSDOCS-1038: Adding docs for new descheduler policy #22063

Merged
merged 1 commit into from
May 20, 2020

Conversation

@bergerhoffer bergerhoffer added peer-review-needed Signifies that the peer review team needs to review this PR branch/enterprise-4.5 labels May 13, 2020
@bergerhoffer bergerhoffer added this to the Future Release milestone May 13, 2020
@openshift-docs-preview-bot

The preview will be available shortly at:

@bergerhoffer
Copy link
Contributor Author

@openshift/team-documentation For peer review please.

@ahardin-rh ahardin-rh added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels May 13, 2020
@ahardin-rh
Copy link
Contributor

LGTM!

@bergerhoffer
Copy link
Contributor Author

@damemi I've updated the parameters per our conversation. Can you please review all changes in this PR to make sure it's accurate and that I've covered everything for the new policy? Thanks!

Preview: https://osdocs-1038-desched--ocpdocs.netlify.app/openshift-enterprise/latest/nodes/scheduling/nodes-descheduler.html

modules/nodes-descheduler-configuring-strategies.adoc Outdated Show resolved Hide resolved
modules/nodes-descheduler-strategies.adoc Outdated Show resolved Hide resolved
@bergerhoffer
Copy link
Contributor Author

Copy link

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
will let QE give the final signoff

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2020
@damemi
Copy link

damemi commented May 15, 2020

/lgtm cancel

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label May 15, 2020
Copy link

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks for the updates!

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2020
@kasturinarra
Copy link

/lgtm

Thanks!!

@bergerhoffer
Copy link
Contributor Author

Thank you both! Merging this in.

@bergerhoffer bergerhoffer merged commit 2fd134b into openshift:master May 20, 2020
@bergerhoffer
Copy link
Contributor Author

/cherrypick enterprise-4.5

@openshift-cherrypick-robot

@bergerhoffer: new pull request created: #22331

In response to this:

/cherrypick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bergerhoffer bergerhoffer deleted the OSDOCS-1038-desched branch October 29, 2020 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.5 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants