Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Virtual Machine #184
Create Virtual Machine #184
Changes from 28 commits
c018028
f8a020b
f0e49e0
8144098
77fedcb
a40f4d6
01869cf
761916d
c4df2cc
2a34aef
e9dca08
b33d1e8
d4b6119
212eda6
7f55e9c
df4fef3
6e21b68
31f12ef
8074819
cdb78a5
615c975
8f5cd41
0b38d6e
6bd7b99
8b210f5
d3af82f
75bd0c8
b391f0f
effe94e
efd68d4
c34ce4a
c2b3602
bf51ab9
1cbc642
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- May as well switch to RHEL 8 in this screen and all others
- I think everything in PF4 is supposed to be capitalized sentence-style except for product names. The “Create Virtual Machine” title and quick action button would then be “Create virtual machine”. Might be worth double-checking.
- Where do help icons go? PF4’s form documentation shows the help icon next to the input label, rather than within a FormGroup. Which is correct? (I hope the documentation)
- Should include an auto-generated name here since that’s the new default behavior.
- "Create new template from configuration" should be disabled when a Template is selected unless they tweak the Flavor of that template.
- Screens use Flavour but text uses ‘merican Flavor, we should check on this 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only thing with the auto generated name is that it might not always be generated. There is a possibility that the feature has been disabled OR they are creating a VM from scratch and haven't chosen any settings yet. This is the only one I left it empty though for that reason. There will be a follow up PR to focus on this feature specifically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Minor version dropdown here should be 8.0 (or whatever's the latest) rather than 7.x. This applies to the next screen too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should align with whatever the OpenShift pattern is here. I've been just putting hyperlinked "Learn more" text after the period of the previous sentence, but I'm not sure that's right either. We should figure that out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 Ya I was just adding this text to be more accessible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should also say that this is just placeholder not actually what it should say. It would hopefully be different for each to allow for a more descriptive text.