Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wire up the new WithAudit filter #15271

Closed
deads2k opened this issue Jul 18, 2017 · 2 comments
Closed

Wire up the new WithAudit filter #15271

deads2k opened this issue Jul 18, 2017 · 2 comments
Assignees
@soltysh @sttts
Labels
kind/post-rebase priority/P1
Milestone
v3.7

Comments

@deads2k
Copy link
Contributor

deads2k commented Jul 18, 2017

The new audit feature has a new filter. I wired the legacy one for the rebase.

@sttts I'm not sure if this is you or @soltysh . It needs to be backward compatible with our existing config.
@deads2k deads2k added this to the 3.7.0 milestone Jul 18, 2017
@deads2k deads2k mentioned this issue Jul 18, 2017
Closed
56 tasks
@sttts
Copy link
Contributor

sttts commented Jul 18, 2017

Will wait until @soltysh is back from vacation before fighting over this :)

@soltysh
Copy link
Contributor

soltysh commented Jul 25, 2017

I claim this issue :)

@soltysh soltysh mentioned this issue Aug 7, 2017
Merged
openshift-merge-robot added a commit that referenced this issue Aug 13, 2017
@openshift-merge-robot
Merge pull request #15657 from soltysh/advanced_audit
200364e 
Automatic merge from submit-queue (batch tested with PRs 15657, 15748)

Switch to the advanced audit backend

Fixes #15271.

@deads2k || @sttts for wiring
@smarterclayton for api change

There are a few changes when turning on the new audit:

1. one line instead of two (previously we've logged the response on separate line), see [old](https://docs.openshift.org/latest/install_config/master_node_configuration.html#master-node-config-audit-config) and new:
```
AUDIT: id="ac14f7c8-1891-4551-9da4-e5075e9d89c6" stage="ResponseComplete" ip="127.0.0.1" method="list" user="test-admin" groups="\"system:authenticated:oauth\",\"system:authenticated\"" as="<self>" asgroups="<lookup>" namespace="test" uri="/api/v1/namespaces/test/pods" response="200"
```
2. the method changed from HTTP action to actual operation performed
3. there's a new field `stage` showing when the event was generated

I'll open a separate PR enabling other alpha features after I sync with @mpbarrett
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@soltysh soltysh

@sttts sttts

Labels
kind/post-rebase priority/P1
Projects
None yet
Milestone
v3.7
Development

No branches or pull requests
3 participants
@soltysh @sttts @deads2k