Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use NewBuilder function in the factory from upstream #15278

Closed
deads2k opened this issue Jul 18, 2017 · 0 comments
Closed

Use NewBuilder function in the factory from upstream #15278

deads2k opened this issue Jul 18, 2017 · 0 comments
Assignees
@fabianofranz @juanvallejo
Labels
kind/post-rebase priority/P1
Milestone
v3.7

Comments

@deads2k
Copy link
Contributor

deads2k commented Jul 18, 2017

The rebase exposed dozens of places we were creating one off factories. We want to be more standard with upstream in their construction.
@deads2k deads2k added this to the 3.7.0 milestone Jul 18, 2017
@deads2k deads2k mentioned this issue Jul 18, 2017
Closed
56 tasks
@juanvallejo juanvallejo mentioned this issue Jul 19, 2017
Merged
openshift-merge-robot added a commit that referenced this issue Aug 2, 2017
@openshift-merge-robot
Merge pull request #15352 from juanvallejo/jvallejo/use-factory-new-b…
8ef052d 
…uilder

Automatic merge from submit-queue

Update oc cmds to use upstream clientcmd/Factory#NewBuilder

Fixes #15278 

1. Makes use of upstream's `util/clientcmd/Factory#NewBuilder` method.
2. Wires through commands' `local` option to the `util/clientcmd/Factory#PrinterForCommand` method (enables local commands to work without a connection to an api server)

cc @openshift/cli-review @deads2k
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fabianofranz fabianofranz

@juanvallejo juanvallejo

Labels
kind/post-rebase priority/P1
Projects
None yet
Milestone
v3.7
Development

No branches or pull requests
3 participants
@fabianofranz @juanvallejo @deads2k