-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cancel-build should take a buildconfig #5193
Comments
No. Maybe you ran it expecting to see usage information. Or hit enter Cancelling is pretty destructive, I don't like the idea of defaulting it. Ben Parees | OpenShift
|
So I run Not that that ever happened to me. I'm asking for a friend... |
|
The I didn't use the output of the I'm still not seeing why its a bad thing to have congruent commands that behave as expected. It would also handle the case of "I looked at |
It seems valid to support this. |
The intent behind |
@Kargakis should we then also support this behavior for logs? |
|
@Kargakis very cool :-) |
With deployments you can have only one deployment active, builds are different, you can have multiple build active and as @liggitt mentioned this command will be ambiguous in that case. |
That's an uncommon case that can be inspected before completing the call. We can simply fail the command in that case. |
With something like "multiple builds are running in parallel". |
Thinking about it, if I was trying to cancel a bc I would expect to cancel all of its builds... No? |
Definitely not. |
Fixed by #8509 |
If I call
oc cancel-build
with a buildconfig that has a single running build, cancel it for me.@bparees
@Kargakis I think you're in this code at the moment.
The text was updated successfully, but these errors were encountered: