-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scope representing full user permissions, default token requests with unspecified scope #10060
Conversation
[test] |
return `See projects you're aware of and the metadata (display name, description, etc) about those projects.` | ||
case UserFull: | ||
return `All permissions of the user.` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Someday we're going to need, "all non-escalating". I can feel it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make this consistent. Either "you/your" everywhere or "user" everywhere.
Other than the question about non-resource URLs, everything else is minor. |
…with unspecified scope
comments addressed |
Evaluated for origin test up to 590fb8c |
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7701/) |
[merge] |
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7714/) (Image: devenv-rhel7_4794) |
https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7712/ failed with bug #10319 and flakes #9548 #9490, re[merge] |
Evaluated for origin merge up to 590fb8c |
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1359035
Default token authorization requests that do not specify a scope to a
user:full
scope which includes all of the user's powers.