Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scope representing full user permissions, default token requests with unspecified scope #10060

Merged
merged 1 commit into from
Aug 10, 2016

Conversation

liggitt
Copy link
Contributor

@liggitt liggitt commented Jul 27, 2016

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1359035

Default token authorization requests that do not specify a scope to a user:full scope which includes all of the user's powers.

@liggitt
Copy link
Contributor Author

liggitt commented Jul 27, 2016

[test]

@liggitt liggitt changed the title WIP - Add scope representing full user permissions, default token requests with unspecified scope Add scope representing full user permissions, default token requests with unspecified scope Aug 9, 2016
return `See projects you're aware of and the metadata (display name, description, etc) about those projects.`
case UserFull:
return `All permissions of the user.`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Someday we're going to need, "all non-escalating". I can feel it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this consistent. Either "you/your" everywhere or "user" everywhere.

@deads2k
Copy link
Contributor

deads2k commented Aug 9, 2016

Other than the question about non-resource URLs, everything else is minor.

@liggitt
Copy link
Contributor Author

liggitt commented Aug 9, 2016

comments addressed

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 590fb8c

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7701/)

@liggitt
Copy link
Contributor Author

liggitt commented Aug 10, 2016

[merge]

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 10, 2016

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7714/) (Image: devenv-rhel7_4794)

@liggitt
Copy link
Contributor Author

liggitt commented Aug 10, 2016

https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7712/ failed with bug #10319 and flakes #9548 #9490, re[merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 590fb8c

@openshift-bot openshift-bot merged commit f1c0be6 into openshift:master Aug 10, 2016
@liggitt liggitt deleted the unscoped-tokens branch August 10, 2016 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants