Changed directory of slave image to /tmp #11041

oatmealraisin · 2016-09-21T14:39:12Z

bparees · 2016-09-21T14:43:38Z

does the master-slave readme need to be updated also, to indicate the need to instantiate the sample template? i seem to recall you ran into issues with missing that step.

mfojtik · 2016-09-21T15:27:23Z

@oatmealraisin @bparees did you find the root cause for why we need to do this? it used to work :-)

bparees · 2016-09-21T15:28:54Z

@mfojtik i'm satisfied to assume something about some permissions changed in the image or the uid the slave is getting launched as.

mfojtik · 2016-09-21T15:30:33Z

@bparees @oatmealraisin can we at least use /tmp/workspace or something similar?

oatmealraisin · 2016-09-21T15:31:50Z

I'm working on the README, testing my changes now

@mfojtik @bparees Whatever you all think is best for the directory. I'll also test /tmp/workspace

bparees · 2016-09-21T15:33:54Z

@mfojtik any particular reason you think it matters? we're specifying the image, we know /tmp is safe to use.

mfojtik · 2016-09-21T16:01:07Z

@bparees during the build the /tmp might be used for temporary artifacts.. i would feel safe if we can isolate the workdir ;-)

bparees · 2016-09-21T16:02:18Z

@mfojtik i'm pretty sure jenkins creates a subdir anyway for the workspace.

but if @oatmealraisin finds that "/tmp/workspace" works, we can update it to that.

oatmealraisin · 2016-09-21T18:16:36Z

@mfojtik @bparees I've changed the tutorial but left it as /tmp. Jenkins automatically creates a workspace directory, and the app breaks with the additional /tmp/workspace. Jenkins breaks trying to mkdir /tmp/workspace/workspace/jenkins

bparees

one minor issue w/ the instructions and then lgtm.

bparees · 2016-09-21T20:04:06Z

examples/jenkins/master-slave/README.md

-```
+  ```
+  # Ruby application template
+  $ oc new-app https://raw.githubusercontent.com/openshift/origin/master/examples/jenkins/application-template.json


this is installing/instantiating a template which is different from installing a template (as the other 2 commands do), so i think this needs to be broken out as a separate step so it's not under "install the provided templates"

oatmealraisin · 2016-09-21T21:26:55Z

@bparees Made oc new-app its own step, ptal?

bparees · 2016-09-22T07:33:26Z

@oatmealraisin squash and lgtm.

Added step to Master->Slave tutorial This directs the user to create the ruby application template, which is critical to the success of the tutorial. Also fixed a bug with ordered list

oatmealraisin · 2016-09-22T13:21:46Z

@bparees squashed, merge?

bparees · 2016-09-22T13:52:12Z

[merge]

openshift-bot · 2016-09-22T13:57:44Z

[Test]ing while waiting on the merge queue

oatmealraisin · 2016-09-22T15:14:07Z

[test]

oatmealraisin · 2016-09-23T14:42:54Z

Flake #11074 , [test]

oatmealraisin · 2016-09-23T19:52:22Z

Flake #11079, [test]

bparees · 2016-09-24T03:22:31Z

[merge]

Ben Parees | OpenShift

On Sep 24, 2016 04:32, "OpenShift Bot" notifications@github.com wrote:

continuous-integration/openshift-jenkins/merge FAILURE (
https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/9237/)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11041 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEvl3g9CBXolr6P36aCvFqqAyG9pYfPdks5qtIvEgaJpZM4KC4iH
.

bparees · 2016-09-24T07:10:56Z

[merge]

Ben Parees | OpenShift

On Sep 24, 2016 07:37, "OpenShift Bot" notifications@github.com wrote:

continuous-integration/openshift-jenkins/merge FAILURE (
https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/9241/)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11041 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEvl3gNFtbO72jtxmIJCE1YeIFdIMgGoks5qtLcegaJpZM4KC4iH
.

oatmealraisin · 2016-09-24T14:15:15Z

@bparees Any idea how I could be causing this failure? I keep getting the same one.

bparees · 2016-09-24T21:18:13Z

@oatmealraisin the deployments flake is a known flake #11016

The flake here is more concerning but still not due to your changes that i can see:
https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_integration/6320/console

@stevekuznetsov did compilation memory requirements go up again? not sure why everyone wouldn't be seeing this:

++ Building go targets for linux/amd64: cmd/openshift cmd/oc
# github.com/openshift/origin/cmd/openshift
/usr/local/go/pkg/tool/linux_amd64/link: running gcc failed: fork/exec /usr/bin/gcc: cannot allocate memory
[ERROR] PID 7: hack/common.sh:244: `local -a binaries=("$@")` exited with status 1.
[INFO]      Stack Trace: 
[INFO]        1: hack/common.sh:244: `local -a binaries=("$@")`
[INFO]        2: hack/build-cross.sh:20: os::build::build_binaries
[INFO]   Exiting with code 1.
make: *** [build-cross] Error 1

[test]

bparees · 2016-09-25T00:28:15Z

flake #11016
[test]

memory error seems to have gone away this run, so that's a flake too.

On Sat, Sep 24, 2016 at 7:22 PM, OpenShift Bot notifications@github.com
wrote:

continuous-integration/openshift-jenkins/test FAILURE (
https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/9251/)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11041 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEvl3j4R-AdD6jNbuVcBgbcnKYwyI_ltks5qtbC4gaJpZM4KC4iH
.

Ben Parees | OpenShift

oatmealraisin · 2016-09-25T19:39:02Z

Flake #11016, [test]

oatmealraisin · 2016-09-25T19:39:28Z

@bparees Thanks :) was really scratching my head with this one

openshift-bot · 2016-09-25T19:42:19Z

Evaluated for origin test up to a1f3537

openshift-bot · 2016-09-25T21:43:43Z

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/9265/)

bparees · 2016-09-26T02:29:21Z

[merge]

stevekuznetsov · 2016-09-26T11:56:51Z

@bparees yeah, they're slowly creeping up still after the rebase.

openshift-bot · 2016-09-26T12:57:22Z

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/9265/) (Image: devenv-rhel7_5076)

bparees · 2016-09-26T13:00:55Z

#10162
[merge]

openshift-bot · 2016-09-26T13:02:26Z

Evaluated for origin merge up to a1f3537

bparees self-assigned this Sep 21, 2016

bparees requested changes Sep 21, 2016

View reviewed changes

bparees approved these changes Sep 22, 2016

View reviewed changes

Changed directory of slave image to /tmp

a1f3537

Added step to Master->Slave tutorial This directs the user to create the ruby application template, which is critical to the success of the tutorial. Also fixed a bug with ordered list

oatmealraisin mentioned this pull request Sep 23, 2016

TestPrioritiesRegistered flake #11074

Closed

oatmealraisin mentioned this pull request Sep 23, 2016

Flake: extended test [Conformance] deploymentconfigs with revision history limits #11079

Closed

openshift-bot merged commit 46146b0 into openshift:master Sep 26, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Changed directory of slave image to /tmp #11041

Changed directory of slave image to /tmp #11041

oatmealraisin commented Sep 21, 2016

bparees commented Sep 21, 2016

mfojtik commented Sep 21, 2016

bparees commented Sep 21, 2016

mfojtik commented Sep 21, 2016

oatmealraisin commented Sep 21, 2016

bparees commented Sep 21, 2016

mfojtik commented Sep 21, 2016

bparees commented Sep 21, 2016

oatmealraisin commented Sep 21, 2016

bparees left a comment

bparees Sep 21, 2016

oatmealraisin commented Sep 21, 2016

bparees commented Sep 22, 2016

oatmealraisin commented Sep 22, 2016

bparees commented Sep 22, 2016

openshift-bot commented Sep 22, 2016

oatmealraisin commented Sep 22, 2016

oatmealraisin commented Sep 23, 2016 •

edited

Loading

oatmealraisin commented Sep 23, 2016

bparees commented Sep 24, 2016

bparees commented Sep 24, 2016

oatmealraisin commented Sep 24, 2016

bparees commented Sep 24, 2016

bparees commented Sep 25, 2016

oatmealraisin commented Sep 25, 2016

oatmealraisin commented Sep 25, 2016

openshift-bot commented Sep 25, 2016

openshift-bot commented Sep 25, 2016

bparees commented Sep 26, 2016

stevekuznetsov commented Sep 26, 2016

openshift-bot commented Sep 26, 2016 •

edited

Loading

bparees commented Sep 26, 2016

openshift-bot commented Sep 26, 2016

Changed directory of slave image to /tmp #11041

Changed directory of slave image to /tmp #11041

Conversation

oatmealraisin commented Sep 21, 2016

bparees commented Sep 21, 2016

mfojtik commented Sep 21, 2016

bparees commented Sep 21, 2016

mfojtik commented Sep 21, 2016

oatmealraisin commented Sep 21, 2016

bparees commented Sep 21, 2016

mfojtik commented Sep 21, 2016

bparees commented Sep 21, 2016

oatmealraisin commented Sep 21, 2016

bparees left a comment

Choose a reason for hiding this comment

bparees Sep 21, 2016

Choose a reason for hiding this comment

oatmealraisin commented Sep 21, 2016

bparees commented Sep 22, 2016

oatmealraisin commented Sep 22, 2016

bparees commented Sep 22, 2016

openshift-bot commented Sep 22, 2016

oatmealraisin commented Sep 22, 2016

oatmealraisin commented Sep 23, 2016 • edited Loading

oatmealraisin commented Sep 23, 2016

bparees commented Sep 24, 2016

bparees commented Sep 24, 2016

oatmealraisin commented Sep 24, 2016

bparees commented Sep 24, 2016

bparees commented Sep 25, 2016

oatmealraisin commented Sep 25, 2016

oatmealraisin commented Sep 25, 2016

openshift-bot commented Sep 25, 2016

openshift-bot commented Sep 25, 2016

bparees commented Sep 26, 2016

stevekuznetsov commented Sep 26, 2016

openshift-bot commented Sep 26, 2016 • edited Loading

bparees commented Sep 26, 2016

openshift-bot commented Sep 26, 2016

oatmealraisin commented Sep 23, 2016 •

edited

Loading

openshift-bot commented Sep 26, 2016 •

edited

Loading