Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct secret type in oc secrets new-{basic,ssh}auth #11222

Merged
merged 1 commit into from
Oct 18, 2016

Conversation

jim-minter
Copy link
Contributor

fixes #10804

@csrwng
Copy link
Contributor

csrwng commented Oct 11, 2016

LGTM
[test]

@jim-minter
Copy link
Contributor Author

fixed up test script, [test]

@jim-minter
Copy link
Contributor Author

flake #8571
[test]

2 similar comments
@jim-minter
Copy link
Contributor Author

flake #8571
[test]

@jim-minter
Copy link
Contributor Author

flake #8571
[test]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 3838d18

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10002/) (Base Commit: bc0a4dc)

@jim-minter
Copy link
Contributor Author

flake #10773
flake #11240

@csrwng
Copy link
Contributor

csrwng commented Oct 17, 2016

[merge]

@csrwng
Copy link
Contributor

csrwng commented Oct 18, 2016

#11240
[merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 3838d18

@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 18, 2016

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10179/) (Base Commit: f6bd74b) (Image: devenv-rhel7_5195)

@openshift-bot openshift-bot merged commit a941850 into openshift:master Oct 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating basicauth or sshauth secret will create secret with type Opaque
3 participants