Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement SSPI Support on Windows (oc Kerberos) #11371

Merged
merged 4 commits into from
Jul 13, 2018
Merged

Implement SSPI Support on Windows (oc Kerberos) #11371

merged 4 commits into from
Jul 13, 2018

Conversation

enj
Copy link
Contributor

@enj enj commented Oct 14, 2016 •
edited
Loading

Trello ref: https://trello.com/c/5BrQfA4H

TODO:

@enj
Copy link
Contributor Author

enj commented Oct 14, 2016

[test] to make sure it still builds...

@marun
Copy link
Contributor

marun commented Oct 14, 2016

flake #11374 re-[test]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 9763453

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10877/) (Base Commit: 44f877c)

@openshift-bot openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 20, 2016
@enj enj mentioned this pull request Dec 22, 2016
Closed
@openshift-bot openshift-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 21, 2017
@openshift-bot openshift-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 23, 2017
@openshift-bot openshift-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 4, 2017
@openshift-bot openshift-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 23, 2017
@openshift-bot openshift-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 14, 2017
@liggitt liggitt reopened this Jun 19, 2017
@smarterclayton
Copy link
Contributor

Still hoping, huh?

@enj
Copy link
Contributor Author

enj commented Jun 20, 2017

Still hoping, huh?

It already works, just is a pain to test...

@openshift-bot openshift-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 30, 2017
@openshift-bot
Copy link
Contributor

Origin Action Required: Pull request cannot be automatically merged, please rebase your branch from latest HEAD and push again

@enj
Copy link
Contributor Author

enj commented Jul 10, 2018

/retest

@enj
Copy link
Contributor Author

enj commented Jul 10, 2018

/refresh

@simo5
Copy link
Contributor

simo5 commented Jul 10, 2018

/retest

6 similar comments
@enj
Copy link
Contributor Author

enj commented Jul 10, 2018

/retest

@enj
Copy link
Contributor Author

enj commented Jul 11, 2018

/retest

@enj
Copy link
Contributor Author

enj commented Jul 11, 2018

/retest

@simo5
Copy link
Contributor

simo5 commented Jul 11, 2018

/retest

@enj
Copy link
Contributor Author

enj commented Jul 11, 2018

/retest

@enj
Copy link
Contributor Author

enj commented Jul 11, 2018

/retest

@enj
Copy link
Contributor Author

enj commented Jul 11, 2018

/retest
/test cmd

@enj
Copy link
Contributor Author

enj commented Jul 11, 2018

/retest

1 similar comment
@simo5
Copy link
Contributor

simo5 commented Jul 11, 2018

/retest

@simo5
Copy link
Contributor

simo5 commented Jul 12, 2018

@deads2k this PR was fully green yesterday, now it is all red again due to flakes, can we green button please ? I think we suffered enough the CI woes!

/retest

@enj
Copy link
Contributor Author

enj commented Jul 12, 2018

/test cmd

@simo5
Copy link
Contributor

simo5 commented Jul 12, 2018

/retest

2 similar comments
@simo5
Copy link
Contributor

simo5 commented Jul 12, 2018

/retest

@enj
Copy link
Contributor Author

enj commented Jul 13, 2018

/retest

enj added 4 commits July 13, 2018 03:40
@enj
Fix spelling negotiater -> negotiator
5329244 
This does not change the behavior of the code.

Signed-off-by: Monis Khan <mkhan@redhat.com>
@enj
Vendor github.com/alexbrainman/sspi
396d953 
Required for SSPI support on Windows (for oc Kerberos).  This
dependency is owned by the auth team.

Signed-off-by: Monis Khan <mkhan@redhat.com>
@enj
bump(*)
93c00d2 
Signed-off-by: Monis Khan <mkhan@redhat.com>
@enj
Implement SSPI Support on Windows (oc Kerberos)
919477b 
This change is highly experimental and includes no tests (because
you need an automated extended test with a fully configured Windows
Active Directory server to actually test this).

Signed-off-by: Monis Khan <mkhan@redhat.com>
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2018
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@enj enj added the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2018
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 13, 2018 •
edited
Loading

@enj: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/unit 7d3bd2d link /test unit
ci/openshift-jenkins/gcp 77f53f9 link /test gcp
ci/openshift-jenkins/extended_builds a02e778 link /test extended_builds

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@enj
Copy link
Contributor Author

enj commented Jul 13, 2018

/retest

@openshift-merge-robot openshift-merge-robot merged commit fdde50e into openshift:master Jul 13, 2018
@enj
Copy link
Contributor Author

enj commented Jul 13, 2018

1 year, 9 months and a million flakes later...

@deads2k
Copy link
Contributor

deads2k commented Jul 13, 2018

a million flakes later...

pulls accepted :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simo5 simo5 simo5 left review comments

Assignees

@liggitt liggitt

@simo5 simo5

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. sig/security size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. vendor-update Touching vendor dir or related files
Projects
None yet
Milestone
v3.11
Development

Successfully merging this pull request may close these issues.