Add oc serviceaccounts create-kubeconfig
#12082
Conversation
smarterclayton
force-pushed
the
create_kubeconfig
branch
from
c4e534f to
97bc164
Compare
|
@openshift/cli-review |
|
@fabianofranz LGTM |
|
@smarterclayton updated docs look fine, but travis seems to be generating outdated docs when checking |
|
@juanvallejo can you reproduce it ? |
Yeah, see #12058 |
|
@juanvallejo The Travis job in this PR is on some old commit, maybe it's correct for the commit it was checking for? Kick it and see if it happens with the current state of this PR. |
smarterclayton
force-pushed
the
create_kubeconfig
branch
from
97bc164 to
a684052
Compare
|
[test] |
|
Updated.
…On Thu, Dec 1, 2016 at 1:39 PM, OpenShift Bot ***@***.***> wrote:
continuous-integration/openshift-jenkins/test SUCCESS (
https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11872/) (Base
Commit: a38151f
<a38151f>
)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#12082 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABG_pySUST39FmN6CecoCUlBuaSjSUXZks5rDxRIgaJpZM4LA9Wc>
.
|
|
|
||
| var ( | ||
| createKubeconfigLong = templates.LongDesc(` | ||
| Create a .kubeconfig file that will utilize this service account. |
There was a problem hiding this comment.
Create where? Might be worth to mention it just gets printed to the output, and add an example that redirects the output to a file.
| const ( | ||
| CreateKubeconfigRecommendedName = "create-kubeconfig" | ||
|
|
||
| createKubeconfigShort = `Create a .kubeconfig file for a service account` |
There was a problem hiding this comment.
In other places (like oc config) we refer to it as "kubeconfig" (without the dot) or "client config file". I'd suggest "kubeconfig", the long desc could add a mention to "client config" (without "file" given this doesn't output to a file by default).
There was a problem hiding this comment.
kubeconfig instead of .kubeconfig in this line.
There was a problem hiding this comment.
Also I'd suggest to s/Create/Generate
|
Worth adding some |
smarterclayton
force-pushed
the
create_kubeconfig
branch
2 times, most recently
from
2125074 to
e1c05f4
Compare
|
[test] flake "no route to fedora cloud infra" #9379 |
|
[test] fedora copr |
|
Any additional comments? |
| const ( | ||
| CreateKubeconfigRecommendedName = "create-kubeconfig" | ||
|
|
||
| createKubeconfigShort = `Create a .kubeconfig file for a service account` |
There was a problem hiding this comment.
kubeconfig instead of .kubeconfig in this line.
| const ( | ||
| CreateKubeconfigRecommendedName = "create-kubeconfig" | ||
|
|
||
| createKubeconfigShort = `Create a .kubeconfig file for a service account` |
There was a problem hiding this comment.
Also I'd suggest to s/Create/Generate
| createKubeconfigLong = templates.LongDesc(` | ||
| Generate a kubeconfig file that will utilize this service account. | ||
|
|
||
| The .kubeconfig will reference the service account token and use the current server, |
There was a problem hiding this comment.
kubeconfig instead of .kubeconfig in this line
smarterclayton
force-pushed
the
create_kubeconfig
branch
from
e1c05f4 to
886dcbe
Compare
|
Evaluated for origin test up to 886dcbe |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11946/) (Base Commit: b20ed8d) |
|
[merge] |
|
Evaluated for origin merge up to 886dcbe |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11962/) (Base Commit: ec171a1) (Image: devenv-rhel7_5472) |
No description provided.