UPSTREAM: 44798: Cinder: Automatically Generate Zone if Availability in Storage Class is not Configured #14159
+80
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in Storage Class is not Configured Backport of Kubernetes PR #44798 (kubernetes/kubernetes#44798). In case the availability parameter is not configured in a cinder Storage Class the cinder volume is always provisioned in the nova availability zone. That is incorrect. Now, the cinder volume is provisioned in a zone that is generated by an algorithm from the set of zone available in the cluster. Positive side-effect: cinder volumes for individual pods in a StatefulSet are provisioned in unique zones. This increases the StatefulSet resilience.
|
lgtm |
|
Evaluated for origin merge up to 879fc71 |
|
[Test]ing while waiting on the merge queue |
pospispa
pushed a commit
to pospispa/openshift-docs
that referenced
this pull request
May 12, 2017
…n Storage Class is not Configured Backport of Kubernetes PR openshift#3693 (kubernetes/website#3693). Corresponding source code OpenShift origin PR openshift#14159 (openshift/origin#14159). Documents the Cinder volume plugin behaviour in case the availability parameter in a Storage Class is not configured. Improves description of aws-ebs and gce-pd volume plugins behavior in case zone parameter in a Storage Class is not configured.
|
flake: #14161 |
|
Evaluated for origin test up to 879fc71 |
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/1391/) (Base Commit: f24a57f) |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/631/) (Base Commit: c48c4ea) (Image: devenv-rhel7_6228) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of Kubernetes PR kubernetes/kubernetes#44798.
In case the
availabilityparameter is not configured in a cinder Storage Class the cinder volume is always provisioned in thenovaavailability zone. That is incorrect.Now, the cinder volume is provisioned in a zone that is generated by an algorithm from the set of zones available in the cluster.
Positive side-effect: cinder volumes for individual pods in a StatefulSet are provisioned in unique zones. This increases the StatefulSet resilience.
IMPORTANT: the backport was NOT tested. Testing requires an OpenStack cluster with at least 2 availability zones.
This PR resolves this bug: https://bugzilla.redhat.com/show_bug.cgi?id=1447568
Corresponding documentation PR: openshift/openshift-docs#4409
@jsafrane @rootfs PTAL
@childsb @eparis please, merge.