UPSTREAM: 46516: kubelet was sending negative allocatable values #14379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekwaynecarr
force-pushed
the
bug-too-large-reservation
branch
from
50a6d7d
to
6e57276
Compare
|
[test] |
derekwaynecarr
force-pushed
the
bug-too-large-reservation
branch
from
6e57276
to
177e943
Compare
|
[test] |
|
@liggitt -- ptal |
liggitt
reviewed
May 30, 2017
| @@ -574,6 +574,11 @@ func (kl *Kubelet) setNodeStatusMachineInfo(node *v1.Node) { | |||
| value.Sub(res) | |||
| } | |||
| node.Status.Allocatable[k] = value | |||
|
nit on duplicated line, LGTM otherwise |
|
continuous-integration/openshift-jenkins/test Waiting: Determining build queue position |
derekwaynecarr
force-pushed
the
bug-too-large-reservation
branch
from
177e943
to
c7f261c
Compare
|
Evaluated for origin test up to c7f261c |
|
fixed nit [merge][severity: blocker] |
|
Evaluated for origin merge up to c7f261c |
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/1848/) (Base Commit: 1c38059) |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/847/) (Base Commit: 96f1865) (Extended Tests: blocker) (Image: devenv-rhel7_6289) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1455420
xref kubernetes/kubernetes#46516
xref kubernetes/kubernetes#46628