Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for DC conditions #14877

Merged
merged 1 commit into from
Jun 27, 2017
Merged

Update documentation for DC conditions #14877

merged 1 commit into from
Jun 27, 2017

Conversation

0xmichalis
Copy link
Contributor

Fixes #14855

@mfojtik @jim-minter

Signed-off-by: Michail Kargakis mkargaki@redhat.com

@mfojtik
Copy link
Contributor

mfojtik commented Jun 26, 2017

@Kargakis ❤️ it

don't you need to update swagger && friends?

[test]

@0xmichalis
Copy link
Contributor Author

don't you need to update swagger && friends?

No, this is not part of the schema, merely the value of a condition.

@0xmichalis
Copy link
Contributor Author

#14829 [test]

@0xmichalis
Copy link
Contributor Author

@mfojtik lgty?

@mfojtik
Copy link
Contributor

mfojtik commented Jun 26, 2017

[merge]

@deads2k
Copy link
Contributor

deads2k commented Jun 26, 2017

re[test]

@openshift-bot openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 26, 2017
@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 27, 2017

continuous-integration/openshift-jenkins/merge Waiting: You are in the build queue at position: 14

Signed-off-by: Michail Kargakis <mkargaki@redhat.com>
@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 14ff57d

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 14ff57d

@openshift-bot openshift-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 27, 2017
@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2715/) (Base Commit: 533affe) (PR Branch Commit: 14ff57d)

@smarterclayton smarterclayton merged commit 2f9d6cb into openshift:master Jun 27, 2017
@0xmichalis 0xmichalis deleted the document-progressing-condition branch June 27, 2017 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants