Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.5] Update lastTriggeredImage if not set when instantiating DCs #15139

Closed
wants to merge 1 commit into from
Closed

[1.5] Update lastTriggeredImage if not set when instantiating DCs #15139

wants to merge 1 commit into from

Conversation

0xmichalis
Copy link
Contributor

Otherwise, the endpoint will think that the image is missing
from the cluster in cases where the image hash is already set
but the lastTriggeredImage is not set.

Fixes #15136

Signed-off-by: Michail Kargakis mkargaki@redhat.com

@0xmichalis
Copy link
Contributor Author

[test]

@0xmichalis 0xmichalis added kind/bug Categorizes issue or PR as related to a bug. priority/P1 labels Jul 11, 2017
@0xmichalis 0xmichalis added this to the 1.5.x milestone Jul 11, 2017
@0xmichalis
Copy link
Contributor Author

Blocked on #15144

@0xmichalis
Copy link
Contributor Author

Master pick: #15145

@0xmichalis 0xmichalis changed the title Update lastTriggeredImage if not set when instantiating DCs [1.5] Update lastTriggeredImage if not set when instantiating DCs Jul 11, 2017
@smarterclayton
Copy link
Contributor

Test failure on gce was because we changed the DNS exclude in 3.6 but didn't have an impact here.

@0xmichalis
Update lastTriggeredImage if not set when instantiating DCs
07b194c 
Otherwise, the endpoint will think that the image is missing
from the cluster in cases where the image hash is already set
but the lastTriggeredImage is not set.

Signed-off-by: Michail Kargakis <mkargaki@redhat.com>
@openshift openshift deleted a comment from openshift-bot Jul 13, 2017
@0xmichalis
Copy link
Contributor Author

0xmichalis commented Jul 13, 2017 •
edited
Loading

Already merged in master and the issue that was blocking this getting merged is now fixed so [merge]

@0xmichalis
Copy link
Contributor Author

s/not/now/

@0xmichalis
Copy link
Contributor Author

[merge][severity: blocker]

@smarterclayton
Copy link
Contributor

[test]

@0xmichalis
Copy link
Contributor Author

[test] #15200 #15186 #15201

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 07b194c

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/merge FAILURE (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/1289/) (Base Commit: 758a7a1) (PR Branch Commit: 07b194c) (Extended Tests: blocker)

@0xmichalis
Copy link
Contributor Author

[test] #15200 #15186 #15201

@0xmichalis
Copy link
Contributor Author

#15209 [test]

@0xmichalis
Copy link
Contributor Author

#15209 [test]

@0xmichalis
Copy link
Contributor Author

@jhadvig this is still broken :(

@jhadvig
Copy link
Member

jhadvig commented Jul 20, 2017

#15209 [test]

@0xmichalis
Copy link
Contributor Author

#15201 #15209 [test]

@openshift-merge-robot openshift-merge-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 24, 2017
@0xmichalis
Copy link
Contributor Author

One issue down

[test]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 07b194c

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/3475/) (Base Commit: e43c61d) (PR Branch Commit: 07b194c)

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2017
@openshift-merge-robot openshift-merge-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2017
@0xmichalis
Copy link
Contributor Author

/approve no-issue

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2017
@0xmichalis 0xmichalis added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2017
@0xmichalis
Copy link
Contributor Author

/test all

@0xmichalis
Copy link
Contributor Author

/test unit

because #13068

/test extended_conformance_install_update

because #15545

/test extended_conformance_gce

because #14468

@stevekuznetsov
Copy link
Contributor

/test end_to_end

@0xmichalis
Copy link
Contributor Author

/retest

1 similar comment
@0xmichalis
Copy link
Contributor Author

/retest

@0xmichalis 0xmichalis removed the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2017
@0xmichalis
Copy link
Contributor Author

/test all

@0xmichalis
Copy link
Contributor Author

@mfojtik @tnozicka can you guys move this forward? Last time I checked, merging in release-1.5 was blocked.

@openshift-merge-robot openshift-merge-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2017
@0xmichalis
Copy link
Contributor Author

/retest

@0xmichalis
Copy link
Contributor Author

/approve

@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kargakis
We suggest the following additional approver: mfojtik

Assign the PR to them by writing /assign @mfojtik in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

@Kargakis: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_templates 07b194c link /test extended_templates
ci/openshift-jenkins/end_to_end 07b194c link /test end_to_end
ci/openshift-jenkins/integration 07b194c link /test integration
ci/openshift-jenkins/extended_conformance_install_update 07b194c link /test extended_conformance_install_update
ci/openshift-jenkins/extended_conformance_gce 07b194c link /test extended_conformance_gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@0xmichalis 0xmichalis mentioned this pull request Sep 10, 2017
Closed
@0xmichalis
Copy link
Contributor Author

Giving up on release-1.5

@0xmichalis 0xmichalis closed this Sep 10, 2017
@0xmichalis 0xmichalis deleted the fix-instantiating-templates-with-real-images branch September 10, 2017 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mfojtik mfojtik

Labels
blocked kind/bug Categorizes issue or PR as related to a bug. priority/P1 size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
1.5.x
Development

Successfully merging this pull request may close these issues.
8 participants
@0xmichalis @smarterclayton @openshift-bot @jhadvig @stevekuznetsov @openshift-merge-robot @openshift-ci-robot @mfojtik