Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct the url for the memory stats in the router test #15482

Merged
merged 1 commit into from
Jul 28, 2017
Merged

Correct the url for the memory stats in the router test #15482

merged 1 commit into from
Jul 28, 2017

Conversation

knobunc
Copy link
Contributor

@knobunc knobunc commented Jul 26, 2017

We were missing the debug=1 argument on the memory stats, so were getting them in a binary format. With the flag added we pass tests properly.

Fixes #15356

@knobunc
Correct the url for the memory stats in the router test
9f6702a 
We were missing the debug=1 argument on the memory stats, so were getting them in a binary format.  With the flag added we pass tests properly.

Fixes openshift#15356
@knobunc knobunc self-assigned this Jul 26, 2017
@knobunc knobunc requested a review from smarterclayton July 26, 2017 20:38
@openshift-merge-robot openshift-merge-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 26, 2017
@knobunc
Copy link
Contributor Author

knobunc commented Jul 26, 2017

@openshift/networking PTAL

@smarterclayton
Copy link
Contributor

So why did this start failing?

@knobunc
Copy link
Contributor Author

knobunc commented Jul 27, 2017

It looks like this happened with a change to WriteHeapProfile to make it call WriteTo with a 0 for the debug arg (https://golang.org/pkg/runtime/pprof/#Profile.WriteTo).

I think it is this commit: golang/go@cbab65f

@knobunc
Copy link
Contributor Author

knobunc commented Jul 27, 2017

/retest

@smarterclayton
Copy link
Contributor

/lgtm
/approve no-issue

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knobunc, smarterclayton

Associated issue requirement bypassed by: smarterclayton

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2017
@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 15486, 15482)

@openshift-merge-robot openshift-merge-robot merged commit 9e258e3 into openshift:master Jul 28, 2017
@rhcarvalho rhcarvalho mentioned this pull request Jul 28, 2017
Merged
@knobunc knobunc deleted the issue/15356-bad-stats-test branch July 28, 2017 12:56
@sdodson
Copy link
Member

sdodson commented Jul 28, 2017

YAY! openshift-ansible merges again, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@smarterclayton smarterclayton

@knobunc knobunc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/routing lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@knobunc @smarterclayton @openshift-merge-robot @sdodson @openshift-ci-robot