Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename deploy.* imports to apps.* #16281

Merged
merged 1 commit into from
Dec 15, 2017

Conversation

soltysh
Copy link
Contributor

@soltysh soltysh commented Sep 11, 2017

Followup to #16202.

@mfojtik ptal, since you asked for it :)

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 11, 2017
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 12, 2017
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 28, 2017
@soltysh
Copy link
Contributor Author

soltysh commented Nov 28, 2017

/retest

@soltysh
Copy link
Contributor Author

soltysh commented Nov 28, 2017

This is currently waiting for #17477 to merge first.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 29, 2017
@soltysh
Copy link
Contributor Author

soltysh commented Nov 29, 2017

I'm guessing this will have to wait for #17503 to land first.

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 30, 2017
@soltysh soltysh added this to the 3.9.0 milestone Nov 30, 2017
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 30, 2017
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 5, 2017
@soltysh
Copy link
Contributor Author

soltysh commented Dec 5, 2017

@deads2k this will conflict with the rebase (#17576) so I'm leaving the decision to merge this to you.
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 5, 2017
@soltysh
Copy link
Contributor Author

soltysh commented Dec 5, 2017

/retest

1 similar comment
@soltysh
Copy link
Contributor Author

soltysh commented Dec 5, 2017

/retest

@soltysh
Copy link
Contributor Author

soltysh commented Dec 5, 2017

/hold
until #17576 merges

@soltysh soltysh added the blocked label Dec 5, 2017
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 14, 2017
@soltysh soltysh removed the blocked label Dec 15, 2017
@soltysh
Copy link
Contributor Author

soltysh commented Dec 15, 2017

/hold cancel

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 15, 2017
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 15, 2017
@deads2k
Copy link
Contributor

deads2k commented Dec 15, 2017

First ones look ok. I guess if it builds, we'll call it good.

/lgtm
/queue multiple-rebases

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2017
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, soltysh

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2017
@deads2k
Copy link
Contributor

deads2k commented Dec 15, 2017

/retest

@soltysh
Copy link
Contributor Author

soltysh commented Dec 15, 2017

#17769 is biting this PR every time.

/retest

@soltysh
Copy link
Contributor Author

soltysh commented Dec 15, 2017

/retest

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 15, 2017

@soltysh: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_conformance_install_update 7512dca link /test extended_conformance_install_update
ci/openshift-jenkins/extended_image_registry 56ed4ec link /test extended_image_registry

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit 12d2744 into openshift:master Dec 15, 2017
@soltysh soltysh deleted the rename_imports branch December 19, 2017 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. queue/multiple-rebases size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants