-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cadvisor/runc updates #16419
cadvisor/runc updates #16419
Conversation
I thought you were planning to bump, not pick. |
@deads2k looked fairly impossible as a cadvisor bump would pull tons of new/renamed deps and cause conflicts. google/cadvisor@92cca44 Turns out the functionality we were after could be obtained in a small number of picks. |
@sjenning - the picks are fine, we can bump to kube 1.8 release version of cAdvisor when that rebase happens as that had a lot of side-effects. Can you see if we should take any of the following as well: google/cadvisor#1706 Thanks! |
@deads2k - when doing this in kube 1.8, it caused issues with a name change of a dependency, see: kubernetes/kubernetes#51751 ; i will defer to seth on what he found in origin. |
Yeah, I'm going to assume that kube made it through, but if something like our dockerregistry requires conflicting levels it can severely hamper pulling that level into openshift. I'd like to get in front of openshift specific problems that are coming with a rebase. |
pulled in google/cadvisor#1706 google/cadvisor#1679 (google/cadvisor#1681 is just the 0.26 pick) already came in on the last kube bump |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: derekwaynecarr, sjenning The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
Automatic merge from submit-queue |
Support CRI-O:
google/cadvisor#1741
Fix memory stats:
google/cadvisor#1728
opencontainers/runc#1378
@derekwaynecarr