Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPSTREAM: 53167: Do not GC exited containers in running pods #16896

Merged
merged 1 commit into from
Oct 20, 2017
Merged

UPSTREAM: 53167: Do not GC exited containers in running pods #16896

merged 1 commit into from
Oct 20, 2017

Conversation

sjenning
Copy link
Contributor

kubernetes/kubernetes#53167

xref https://bugzilla.redhat.com/show_bug.cgi?id=1486356

I think this might fix the build issues we are having with init container status corruption

Thanks to @aveshagarwal for spotting this getting picked to kube 1.7 👍

@frobware @derekwaynecarr @smarterclayton @vikaslaad

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 16, 2017
@openshift-merge-robot openshift-merge-robot added the vendor-update Touching vendor dir or related files label Oct 16, 2017
@sjenning
Copy link
Contributor Author

/retest

1 similar comment
@sjenning
Copy link
Contributor Author

/retest

@derekwaynecarr
Copy link
Member

/kind bug
/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. kind/bug Categorizes issue or PR as related to a bug. labels Oct 17, 2017
@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2017
@sjenning sjenning mentioned this pull request Oct 17, 2017
Merged
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 17, 2017
@openshift-merge-robot openshift-merge-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 17, 2017
@joelsmith
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, joelsmith, sjenning

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@joelsmith
Copy link
Contributor

/test extended_conformance_gce

@joelsmith
Copy link
Contributor

/retest

openshift-merge-robot added a commit that referenced this pull request Oct 18, 2017
@openshift-merge-robot
Merge pull request #16906 from sjenning/pick-53167-stage
7761e86 
Automatic merge from submit-queue.

[stage] UPSTREAM: 53167: Do not GC exited containers in running pods

stage pick for #16896

@derekwaynecarr
@sjenning
Copy link
Contributor Author

flake #16870

/retest

@sjenning
Copy link
Contributor Author

provisioning failed
/retest

@joelsmith
Copy link
Contributor

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@sjenning
Copy link
Contributor Author

more flake #16870

/retest

@derekwaynecarr
Copy link
Member

/test extended_conformance_gce

@eparis
Copy link
Member

eparis commented Oct 18, 2017

/test extended_conformance_install_update

@sjenning
Copy link
Contributor Author

last two attempts at conformance_gce failed on TASK [openshift_gcp : Provision GCP resources]

maybe GCP capacity issues? @smarterclayton

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-ci-robot
Copy link

@sjenning: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_conformance_gce 644ea9d link /test extended_conformance_gce
ci/openshift-jenkins/extended_conformance_install_update 644ea9d link /test extended_conformance_install_update

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 16896, 16908, 16935, 16898, 16090).

@openshift-merge-robot openshift-merge-robot merged commit dbb1013 into openshift:master Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@joelsmith joelsmith

@derekwaynecarr derekwaynecarr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. vendor-update Touching vendor dir or related files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@sjenning @derekwaynecarr @joelsmith @openshift-merge-robot @openshift-bot @eparis @openshift-ci-robot @soltysh @stevekuznetsov