cleanly execute scheduler and kubecontrollermanager via cobra command #18139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
approved
openshift-ci-robot
added
the
size/L
openshift-merge-robot
added
the
vendor-update
deads2k
force-pushed
the
controller-20
branch
from
5d38be5
to
74598ba
Compare
deads2k
force-pushed
the
controller-20
branch
from
74598ba
to
e8bfdb7
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
openshift-ci-robot
added
size/XL
|
/retest |
2 similar comments
|
/retest |
|
/retest |
soltysh
approved these changes
Jan 19, 2018
| glog.Fatal(err) | ||
| } | ||
| glog.Infof("`kube-controller-manager %v`", args) | ||
| cmd.Run(nil, nil) | ||
| panic(fmt.Sprintf("`kube-controller-manager %v` exited", args)) |
There was a problem hiding this comment.
Is this intentional here?
Yes. Because we can't re-init, we need to die. And if we loop, we'll want to know why
| glog.Fatal(err) | ||
| } | ||
| glog.Infof("`kube-scheduler %v`", args) | ||
| cmd.Run(nil, nil) | ||
| glog.Fatalf("`kube-scheduler %v` exited", args) |
|
Are you planning to merge #18164 first and rebase this? |
I think it lands without conflicts. |
|
Automatic merge from submit-queue (batch tested with PRs 18163, 18139, 18193, 18194, 16180). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found the upstream bug that was preventing this before and fixed it.
After this pull, there is no direct rebase impact for kube controllers except the ones we directly extend. HPA, quota, and SA tokens come to mind.