Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove invalid SuggestFor from prune deployments #18656

Merged
merged 1 commit into from
Mar 7, 2018
Merged

Remove invalid SuggestFor from prune deployments #18656

merged 1 commit into from
Mar 7, 2018

Conversation

nak3
Copy link
Contributor

@nak3 nak3 commented Feb 18, 2018

This patch makes a tiny change to remove invalid SuggestFor

Since cobra has a suggestion based on Levenshtein distance by default,
removing SuggestFor by this patch is not valid.

This patch makes a tiny change to remove invalid SuggestFor

Since cobra has a suggestion based on Levenshtein distance by default,
removing SuggestFor by this patch is not valid.
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 18, 2018
@nak3
Copy link
Contributor Author

nak3 commented Feb 18, 2018

Suggestions for unknown command including SuggestFor is not working on
any of subcommands due to the cobra's behavior spf13/cobra#636.

But regardless of that, this SuggestFor: []string{"deployment", "deployments"}
for oc adm prune deployments is not necessary.

Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 5, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2018
@soltysh
Copy link
Contributor

soltysh commented Mar 7, 2018

/retest

@eparis eparis added this to the v3.10.0 milestone Mar 7, 2018
@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 18835, 18857, 18641, 18656, 18837).

@openshift-merge-robot openshift-merge-robot merged commit e752be6 into openshift:master Mar 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants