-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
oc adm migrate scc: implement a command for converting SCCs to PSPs #18885
Closed
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
7469967
oc adm migrate scc: implement a command for converting SCCs to PSPs.
php-coder 7be8e00
Introduce security.openshift.io/psp-priority annotation on PSP for ho…
php-coder 705ce60
Add PrivilegeEscalation and Sysctl fields to SCC
stlaz cbaed76
SCC->PSP: add PSP resources to roles with SCCs
stlaz aa5260d
import restricts: allow k8s.io pkg/security for pkg/oc
stlaz adb125d
autogen completions
stlaz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| package scc | ||
|
|
||
| import ( | ||
| "fmt" | ||
|
|
||
| "k8s.io/api/core/v1" | ||
| policy "k8s.io/api/policy/v1beta1" | ||
| rbacv1 "k8s.io/api/rbac/v1" | ||
| ) | ||
|
|
||
| func convertCapabilities(inputCapabilities []v1.Capability) []v1.Capability { | ||
| caps := make([]v1.Capability, 0, len(inputCapabilities)) | ||
| for _, capability := range inputCapabilities { | ||
| v1Cap := v1.Capability(string(capability)) | ||
| caps = append(caps, v1Cap) | ||
| } | ||
| return caps | ||
| } | ||
|
|
||
| func int64val(value *int64) string { | ||
| if value == nil { | ||
| return "nil" | ||
| } | ||
|
|
||
| return fmt.Sprintf("%d", *value) | ||
| } | ||
|
|
||
| func createSingleIDRange(min, max int64) []policy.IDRange { | ||
| ranges := make([]policy.IDRange, 1) | ||
| ranges[0] = policy.IDRange{ | ||
| Min: min, | ||
| Max: max, | ||
| } | ||
| return ranges | ||
| } | ||
|
|
||
| func collectSubjectNames(subjects []rbacv1.Subject, accept func(rbacv1.Subject) bool) []string { | ||
| result := []string{} | ||
| for _, subject := range subjects { | ||
| if accept(subject) { | ||
| result = append(result, subject.Name) | ||
| } | ||
| } | ||
| return result | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use explicit alias in these imports, iow.
corev1,policyv1beta, etc. This makes the code more obvious without reading imports.