Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestValidateSecurityContextConstraints: fix "index out of range" panic when there no errors encountered #19123

Merged
merged 1 commit into from
Apr 6, 2018
Merged

TestValidateSecurityContextConstraints: fix "index out of range" panic when there no errors encountered #19123

merged 1 commit into from
Apr 6, 2018

Conversation

php-coder
Copy link
Contributor

TestValidateSecurityContextConstraints panics when expected error isn't present. This is a regression from 6c58566#diff-f8c7bee9ffab811e5d3d9938626f89dfL208 (#17576, 1.9.0 rebase).

This PR reverts that change to make it work again.

@php-coder
validation_test.go(TestValidateSecurityContextConstraints): fix "inde…
39a0244 
…x out of range" panic when there no errors encountered.
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 28, 2018
@php-coder
Copy link
Contributor Author

php-coder commented Mar 28, 2018 •
edited
Loading

/assign @deads2k

CC @simo5

@php-coder
Copy link
Contributor Author

/retest

@php-coder
Copy link
Contributor Author

@deads2k PTAL

1 similar comment
@php-coder
Copy link
Contributor Author

@deads2k PTAL

@deads2k
Copy link
Contributor

deads2k commented Apr 5, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 5, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, php-coder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 5, 2018
@php-coder
Copy link
Contributor Author

/retest

1 similar comment
@php-coder
Copy link
Contributor Author

/retest

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 6, 2018 •
edited
Loading

@php-coder: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/gcp 39a0244 link /test gcp
ci/openshift-jenkins/integration 39a0244 link /test integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 1b26a41 into openshift:master Apr 6, 2018
@php-coder php-coder deleted the fix_scc_validation_test branch April 6, 2018 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adelton adelton Awaiting requested review from adelton

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@php-coder @deads2k @openshift-ci-robot @openshift-merge-robot