Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix LDAP test to catch the correct output. #19328

Merged
merged 1 commit into from
Apr 19, 2018
Merged

Fix LDAP test to catch the correct output. #19328

merged 1 commit into from
Apr 19, 2018

Conversation

simo5
Copy link
Contributor

@simo5 simo5 commented Apr 11, 2018

After 1.10 rebase this test started failing because we now use grouped
APIs by default.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 11, 2018
@simo5
Copy link
Contributor Author

simo5 commented Apr 11, 2018

/test help

@simo5
Copy link
Contributor Author

simo5 commented Apr 11, 2018

/assign @enj

@enj
Copy link
Contributor

enj commented Apr 11, 2018

/test extended_ldap_groups

@enj
Copy link
Contributor

enj commented Apr 11, 2018

/help

Maybe the bot can tell me?

@openshift-ci-robot
Copy link

@enj:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Maybe the bot can tell me?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Apr 11, 2018
@simo5
Copy link
Contributor Author

simo5 commented Apr 12, 2018

/test extended_ldap_groups
/test gcp

@simo5
Copy link
Contributor Author

simo5 commented Apr 12, 2018

/test extended_ldap_groups

@simo5
Copy link
Contributor Author

simo5 commented Apr 12, 2018

Flake #12806

@simo5
Copy link
Contributor Author

simo5 commented Apr 12, 2018

/test extended_ldap_groups

@enj
Copy link
Contributor

enj commented Apr 13, 2018

/lgtm

@simo5 I will open an issue for the DC rollout issue.

The branch job that sends the email was based off of a pre 1.10 rebase AMI, hence why the rollout was working (it probably pulled in a newer version of oc). The test as a whole is broken until that is fixed.

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 13, 2018
@simo5 simo5 removed the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Apr 13, 2018
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2018
@simo5
Copy link
Contributor Author

simo5 commented Apr 13, 2018

/test extended_ldap_groups

@simo5
Copy link
Contributor Author

simo5 commented Apr 13, 2018

No code change just rebased on latest master
/lgtm

@openshift-ci-robot
Copy link

@simo5: you cannot LGTM your own PR.

In response to this:

No code change just rebased on latest master
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@enj
Copy link
Contributor

enj commented Apr 13, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2018
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@enj
Copy link
Contributor

enj commented Apr 14, 2018

/lgtm cancel

Saving CI resources.

Seems like it is stuck because of the failing test. @stevekuznetsov is that expected - the test is not required by CI normally?

@openshift-ci-robot openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 14, 2018
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 17, 2018
@enj
Copy link
Contributor

enj commented Apr 17, 2018

/test extended_ldap_groups

@simo5
Fix LDAP test to catch the correct output.
ceea517 
After 1.10 rebase this test started failing because we now use grouped
APIs by default.

Signed-off-by: Simo Sorce <simo@redhat.com>
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 17, 2018
@enj
Copy link
Contributor

enj commented Apr 18, 2018

Let us see if openshift-eng/aos-cd-jobs#1308 fixes this.

/test extended_ldap_groups
/test extended_gssapi

/lgtm

(Hope is a valid strategy)

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enj, simo5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 18, 2018
@enj
Copy link
Contributor

enj commented Apr 18, 2018

/retest

@enj enj mentioned this pull request Apr 18, 2018
Closed
@enj
Copy link
Contributor

enj commented Apr 18, 2018

/retest

1 similar comment
@simo5
Copy link
Contributor Author

simo5 commented Apr 19, 2018

/retest

@stevekuznetsov
Copy link
Contributor

😱

@openshift-merge-robot openshift-merge-robot merged commit 9402090 into openshift:master Apr 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfojtik mfojtik Awaiting requested review from mfojtik

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@enj enj

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@simo5 @enj @openshift-ci-robot @openshift-bot @stevekuznetsov @openshift-merge-robot