Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.10] imagebuilder fails for certain COPY statements #20051

Merged
merged 1 commit into from
Jun 22, 2018
Merged

[3.10] imagebuilder fails for certain COPY statements #20051

merged 1 commit into from
Jun 22, 2018

Conversation

smarterclayton
Copy link
Contributor

@smarterclayton smarterclayton commented Jun 21, 2018 •
edited
Loading

openshift-ansible can't build via imagebuilder due to COPY dir / copying to /dir/... instead of /...

Ref: openshift/imagebuilder#79

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 21, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2018
@smarterclayton
Copy link
Contributor Author

@bparees @liggitt without this certain images won't build correctly on OpenShift.

@smarterclayton smarterclayton added this to the v3.10 milestone Jun 21, 2018
@smarterclayton smarterclayton changed the title bump: imagebuilder fails for certain COPY statements [3.10] imagebuilder fails for certain COPY statements Jun 21, 2018
@smarterclayton
Copy link
Contributor Author

/test gcp

@smarterclayton
Copy link
Contributor Author

/retest

liggitt
liggitt reviewed Jun 21, 2018
View reviewed changes
glide.lock Outdated
@@ -393,7 +393,7 @@ imports:
subpackages:
- log
- name: github.com/emicklei/go-restful-swagger12
version: 5e28dc7157ebd9247a268c26dd1bee7818aa33f7
version: 76d80a40857969dddc1a4c21d1eb82f7ea20e9f5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know where this sha came from, but it's not in our repo: openshift/emicklei-go-restful-swagger12@76d80a4

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the old sha was correct

Copy link
Contributor Author

@smarterclayton smarterclayton Jun 21, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll clear my glide cache. I just ran update.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that dropped it from glide.

liggitt
liggitt reviewed Jun 21, 2018
View reviewed changes
glide.lock Outdated
@@ -1073,7 +1073,7 @@ imports:
- name: github.com/sirupsen/logrus
version: 89742aefa4b206dcf400792f3bd35b542998eb3b
- name: github.com/skynetservices/skydns
version: 775ef406696380ce92b76e72421e86b6868905d8
version: d3e54b74891269f7d7aa1814af2ca080b294dd29
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here - openshift/skynetservices-skydns@d3e54b7

liggitt
liggitt reviewed Jun 21, 2018
View reviewed changes
vendor/k8s.io/kubernetes/pkg/kubectl/cmd/cp.go Outdated
@@ -244,6 +244,7 @@ func copyFromPod(f cmdutil.Factory, cmd *cobra.Command, cmderr io.Writer, src, d
// stripPathShortcuts removes any leading or trailing "../" from a given path
func stripPathShortcuts(p string) string {
newPath := path.Clean(p)
newPath = strings.TrimLeft(p, "../")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty sure this is reverting #20034, though I have questions about that pick

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That pick is in the origin-3.10-kubernetes-1.10.2 branch, but not picked into origin 3.10 vendor, so it either should be in this branch, or not in the origin-3.10-kubernetes-1.10.2 branch.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, it's picking the fix up from master.

@smarterclayton
Copy link
Contributor Author

/test gcp

@smarterclayton
Copy link
Contributor Author

GCP jenkins job your cranky days are numbered

@smarterclayton smarterclayton force-pushed the bump_imagebuilder branch 2 times, most recently from 4c7b2e9 to 24be11b Compare June 21, 2018 04:47
@smarterclayton
Copy link
Contributor Author

/retest

1 similar comment
@smarterclayton
Copy link
Contributor Author

/retest

@smarterclayton
Copy link
Contributor Author

/retest

may be a real problem, but i don't know how

@smarterclayton
Copy link
Contributor Author

/refresh
/skip

@smarterclayton
Copy link
Contributor Author

Need to clear the job status...

@smarterclayton
Copy link
Contributor Author

/test extended_builds

@liggitt
Copy link
Contributor

liggitt commented Jun 22, 2018 •
edited
Loading

/hold
getting the kube branches straightened out in #20076 so release-3.10 is the source for origin-3.10-kubernetes-1.10.2
will unhold momentarily

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 22, 2018
@smarterclayton
Copy link
Contributor Author

The image_ecosystem failure seems to be 3.10 branch associated - #20069 is failing too.

@liggitt liggitt removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 22, 2018
@smarterclayton
Copy link
Contributor Author

Rebuilding it.

@openshift-bot openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 22, 2018
@openshift-ci-robot openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 22, 2018
@openshift-bot openshift-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 22, 2018
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 22, 2018
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 22, 2018 •
edited
Loading

@smarterclayton: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_image_ecosystem 41cc5a1 link /test extended_image_ecosystem

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@smarterclayton smarterclayton added the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2018
@smarterclayton
Copy link
Contributor Author

labelling

@smarterclayton
Copy link
Contributor Author

/skip extended_image_ecosystem

@smarterclayton smarterclayton merged commit d1dc615 into openshift:release-3.10 Jun 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@stevekuznetsov stevekuznetsov Awaiting requested review from stevekuznetsov

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v3.10
Development

Successfully merging this pull request may close these issues.
4 participants
@smarterclayton @openshift-ci-robot @liggitt @openshift-bot