Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Greetings me as a new SCC maintainer! #20091

Merged
merged 1 commit into from
Jun 25, 2018

Conversation

stlaz
Copy link
Contributor

@stlaz stlaz commented Jun 25, 2018

All hail Slava Semushin

All hail Slava Semushin
@openshift-ci-robot openshift-ci-robot requested review from enj and simo5 June 25, 2018 13:53
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 25, 2018
@php-coder
Copy link
Contributor

PTAL @openshift/sig-security

/lgtm

@openshift-ci-robot openshift-ci-robot added sig/security lgtm Indicates that a PR is ready to be merged. labels Jun 25, 2018
@enj
Copy link
Contributor

enj commented Jun 25, 2018

/lgtm

@stlaz at some point you need to add yourself as a reviewer in all OWNERS files that @simo5 can approve (i.e. all auth related packages).

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enj, php-coder, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 25, 2018
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@php-coder
Copy link
Contributor

/test e2e-gcp

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit e004e65 into openshift:master Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. retest-not-required-docs-only sig/security size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants