Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebase 1.11 force specified kubelet hostname #20129

Closed
wants to merge 74 commits into from

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Jun 28, 2018

No description provided.

deads2k and others added 30 commits June 28, 2018 07:24
@sjenning you probably want to revert this and find the real wiring problem
deads2k and others added 12 commits June 28, 2018 07:26
Underlying gonum/graph assigns conflicting IDs to new nodes after node
deletion. Thus two different nodes amy be assigned the same ID. This
leads to panic when an edge is set between them.

Temporarily disabling event handling until the package is fixed. This
ensures that no new nodes will be added to the graph after the first
node gets removed.

Signed-off-by: Michal Minář <miminar@redhat.com>
@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 28, 2018
@deads2k deads2k force-pushed the rebase-11-force-host branch from d130445 to d53e2c2 Compare June 28, 2018 14:38
@deads2k deads2k force-pushed the rebase-11-force-host branch from d53e2c2 to dd5b4bf Compare June 28, 2018 14:49
@deads2k
Copy link
Contributor Author

deads2k commented Jun 28, 2018

some ci failure

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Jun 28, 2018

@deads2k
Copy link
Contributor Author

deads2k commented Jun 28, 2018

ci failure

/test unit

@mfojtik
Copy link
Contributor

mfojtik commented Jun 28, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, mfojtik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@liggitt liggitt mentioned this pull request Jun 28, 2018
17 tasks
@deads2k deads2k closed this Jun 28, 2018
@deads2k deads2k deleted the rebase-11-force-host branch July 3, 2018 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants