set FileCheckFrequency default properly #20158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
deads2k
reviewed
Jun 29, 2018
| @@ -31,7 +31,7 @@ func ComputeKubeletFlags(startingArgs map[string][]string, options configapi.Nod | |||
| imageTemplate.Latest = options.ImageConfig.Latest | |||
|
|
|||
| path := "" | |||
| var fileCheckInterval int64 | |||
| fileCheckInterval := int64(20) | |||
There was a problem hiding this comment.
do you want that or do you want to only conditionally set the flag at all?
There was a problem hiding this comment.
set conditionally is better. i'll update it.
sjenning
force-pushed
the
fix-file-check-freq
branch
from
ef60ac0 to
ed83a54
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, sjenning The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest |
1 similar comment
|
/retest |
|
/test unit |
|
flake #20219 |
|
/retest |
1 similar comment
|
/retest |
|
/test cross |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removes the need for 91ff3a7
In 3.11, this code was reworked to use Ticker:
https://github.com/openshift/origin/blob/master/vendor/k8s.io/kubernetes/pkg/kubelet/config/file.go#L63-L116
Whose panic exposed that we were defaulting the
--file-check-frequencyflag to 0 in thewrite-flags:https://github.com/openshift/origin/blob/master/pkg/cmd/server/kubernetes/node/options/options.go#L34-L38
@deads2k @smarterclayton @derekwaynecarr