Auto-assign egress IPs from EgressCIDRs #20258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danwinship
added
component/networking
sig/networking
do-not-merge/hold
openshift-ci-robot
added
the
size/XXL
danwinship
force-pushed
the
auto-egress-ip-master
branch
from
5f43ae4 to
2b089ac
Compare
|
/test cross |
openshift-bot
added
the
needs-rebase
danwinship
force-pushed
the
auto-egress-ip-master
branch
from
2b089ac to
7a575ef
Compare
openshift-bot
added
needs-rebase
danwinship
force-pushed
the
auto-egress-ip-master
branch
from
7a575ef to
2074af9
Compare
openshift-bot
removed
the
needs-rebase
danwinship
removed
the
do-not-merge/hold
|
@deads2k we will need approval for the api glide change, once the api change goes in. |
danwinship
force-pushed
the
auto-egress-ip-master
branch
2 times, most recently
from
131c316 to
76cc0aa
Compare
|
/test integration |
|
/test extended_conformance_install |
|
/test integration |
|
/retest |
|
/retest |
openshift-bot
added
the
needs-rebase
danwinship
force-pushed
the
auto-egress-ip-master
branch
from
5973f0a to
2f55c66
Compare
|
New changes are detected. LGTM label has been removed. |
openshift-bot
removed
the
needs-rebase
openshift-ci-robot
added
size/XXL
danwinship
force-pushed
the
auto-egress-ip-master
branch
2 times, most recently
from
32fb13c to
6e2a7bc
Compare
|
/retest |
danwinship
force-pushed
the
auto-egress-ip-master
branch
from
6e2a7bc to
e029a84
Compare
|
bump looks clean /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship, dcbw, deads2k, pravisankar, squeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest |
|
thanks for getting this updated. ready for tagging for merge? |
|
@liggitt yes |
|
readding lgtm from #20258 (comment) |
|
/retest |
1 similar comment
|
/retest |
|
/test gcp |
1 similar comment
|
/test gcp |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on #20155 (the first commit), which moves the EgressIP-tracking code from node/ to common/, and openshift/api#64 (the second commit), which adds HostSubnets.EgressCIDRs, this adds support to the common egressip code for tracking changes to EgressCIDRs and figuring out acceptable allocations of EgressIPs based on that; and adds support to master for actually updating HostSubnet objects to reflect these new figured-out allocations.
(This PR does not include HA.)