Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove openshift start node and cut kubelet dependencies #20344

Merged
merged 6 commits into from
Aug 14, 2018
Merged

Remove openshift start node and cut kubelet dependencies #20344

merged 6 commits into from
Aug 14, 2018

Conversation

smarterclayton
Copy link
Contributor

The kubelet is now only launched via hyperkube kubelet. Remove openshift start.

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 18, 2018
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 18, 2018
@smarterclayton smarterclayton force-pushed the goodbye_kubelet branch 6 times, most recently from 728864e to 4b3bf59 Compare July 19, 2018 13:46
@smarterclayton
Copy link
Contributor Author

/test gcp

@smarterclayton
Copy link
Contributor Author

/test gcp

3 similar comments
@smarterclayton
Copy link
Contributor Author

/test gcp

@smarterclayton
Copy link
Contributor Author

/test gcp

@smarterclayton
Copy link
Contributor Author

/test gcp

@smarterclayton smarterclayton mentioned this pull request Jul 25, 2018
Merged
@smarterclayton
Copy link
Contributor Author

/retest

@smarterclayton
Copy link
Contributor Author

@deads2k this is ready for review

@deads2k
Copy link
Contributor

deads2k commented Aug 6, 2018

@smarterclayton I'm ready if you are. 3.11?

/test all

@openshift-bot openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 9, 2018
@openshift-bot openshift-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 12, 2018
@smarterclayton smarterclayton force-pushed the goodbye_kubelet branch 3 times, most recently from 27e65c9 to 62ce9e5 Compare August 14, 2018 13:19
@smarterclayton
Copy link
Contributor Author

I think we should do this in 3.11

deads2k
deads2k reviewed Aug 14, 2018
View reviewed changes
pkg/cmd/server/start/start_master.go
@@ -84,6 +85,19 @@ func NewCommandStartMaster(basename string, out, errout io.Writer) (*cobra.Comma
Long: fmt.Sprintf(masterLong, basename),
Run: func(c *cobra.Command, args []string) {
kcmdutil.CheckErr(options.Complete())

if options.PrintIP {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eventually this will go away too. Why move it here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need it for like a billion test cases and tests. Everything using start went to using start master, so I moved it here.

deads2k
deads2k reviewed Aug 14, 2018
View reviewed changes
pkg/cmd/server/start/start_network.go Outdated
"github.com/openshift/origin/pkg/version"
)

type NodeOptions struct {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name isn't correct anymore

deads2k
deads2k reviewed Aug 14, 2018
View reviewed changes
test/util/server/server.go Outdated
@@ -422,7 +328,7 @@ func StartConfiguredNode(nodeConfig *configapi.NodeConfig, components *utilflags
return err
}

if err := start.StartNode(*nodeConfig, components, wait.NeverStop); err != nil {
if err := start.StartNode(*nodeConfig, components); err != nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is starting the network?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I can rename.

@deads2k
Copy link
Contributor

deads2k commented Aug 14, 2018

Some questions. Nothing fundamental.

@smarterclayton
Copy link
Contributor Author

Did the renames

@smarterclayton
Copy link
Contributor Author

/retest

@deads2k
Copy link
Contributor

deads2k commented Aug 14, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 14, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [deads2k,smarterclayton]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit b5f4f96 into openshift:master Aug 14, 2018
@dmage dmage mentioned this pull request Aug 15, 2018
Closed
@adambkaplan adambkaplan mentioned this pull request Aug 15, 2018
Closed
@ricardoferreiracosta08 ricardoferreiracosta08 mentioned this pull request May 16, 2019
Closed
@adellape adellape mentioned this pull request Dec 17, 2019
Closed
@adellape adellape mentioned this pull request Apr 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k deads2k left review comments

@enj enj Awaiting requested review from enj

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@smarterclayton @deads2k @openshift-ci-robot @openshift-bot @openshift-merge-robot