remove build helpers from api packages #20399
Conversation
openshift-ci-robot
added
size/XL
| } | ||
| return sourceType | ||
| } | ||
|
|
||
| // LabelValue returns a string to use as a value for the Build |
There was a problem hiding this comment.
This method is highly questionable. It's being used on an already compressed name and if the field it's setting cannot be set it would actually be better to fail since we really don't want to compress that value-space.
There was a problem hiding this comment.
it's not an already compressed name in the case that we've taken the name and appended a sequence number to it, which i'm pretty sure is how we ended up needing this.
(someone has a buildconfig w/ a maxed out name. Without this logic we then append "-1" to it and fail to create the label).
not entirely sure i understand the motivation. Don't you need to create new external versions of these helpers (in an appropriate location)? so what good does moving them do? I can imagine that some of them might not be needed anymore once you create external versions of them for oc requirements, but not sure why the internal versions need to be moved out of the internal api package? I'm not against it per se, just trying to understand. |
You can't do it with a |
|
/test extended_builds |
openshift-bot
added
the
needs-rebase
openshift-bot
removed
the
needs-rebase
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, juanvallejo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
/test gcp |
|
/retest |
|
/test all |
|
/retest |
Trying to switch oc to externals leads to trying to switch helpers to externals, leads to finding api helpers (no other deps) in an api package that needs to be pulled out.
@bparees @mfojtik @juanvallejo @soltysh