Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix router mutual tls bug if no ca is specified. #20476

Merged
merged 1 commit into from
Jul 31, 2018
Merged

Fix router mutual tls bug if no ca is specified. #20476

merged 1 commit into from
Jul 31, 2018

Conversation

ramr
Copy link
Contributor

@ramr ramr commented Jul 31, 2018

fixes bugz #1608759

Test:

$ oc adm router --latest-images=true  --mutual-tls-auth=optional
or  
$ oc adm router --latest-images=true  --mutual-tls-auth=required

$ # And with a CA:
$ #  oc adm router --latest-images=true  --mutual-tls-auth=optional  \
$ # --mutual-tls-auth-ca=_ramr/nodejs-header-echo/config/CA/cacert.pem

/cc @openshift/sig-network-edge

@openshift-ci-robot openshift-ci-robot added sig/network-edge size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 31, 2018
@Miciah
Copy link
Contributor

Miciah commented Jul 31, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2018
@ironcladlou
Copy link
Contributor

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ironcladlou, Miciah, ramr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2018
@ironcladlou
Copy link
Contributor

/test extended_conformance_install

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

pravisankar
pravisankar approved these changes Jul 31, 2018
View reviewed changes
Copy link

@pravisankar pravisankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit b557a5e into openshift:master Jul 31, 2018
@ramr ramr deleted the mtls-bugfix branch July 31, 2018 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pravisankar pravisankar pravisankar approved these changes

Assignees

@ironcladlou ironcladlou

@Miciah Miciah

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. sig/network-edge size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ramr @Miciah @ironcladlou @openshift-ci-robot @openshift-bot @pravisankar @openshift-merge-robot