HA for fully-automatic egress IPs #20485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
approved
danwinship
force-pushed
the
egress-ip-master-ha
branch
from
cb88e72 to
369f28a
Compare
|
/retest |
1 similar comment
|
/retest |
|
/retest |
and don't allocate egress IPs to offline nodes
danwinship
force-pushed
the
egress-ip-master-ha
branch
from
369f28a to
31c3218
Compare
squeed
approved these changes
Aug 24, 2018
dcbw
approved these changes
Aug 28, 2018
| select { | ||
| case <-stop: | ||
| return | ||
| default: |
There was a problem hiding this comment.
Would it be more idomatic to do something like:
var timeout time.Duration
select {
case <-stop:
return
case <-time.After(timeout):
start := time.Now()
retry := eim.check(retry)
if !retry {
// If less than pollInterval has passed since start, then sleep until it has
timeout = time.Until(start.Add(pollInterval))
}
}
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship, dcbw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracks node online/offline state and handles reassigning egress IPs as needed.
The tracking code is very similar to the semi-automatic tracking code, but couldn't easily be shared since we don't do the OVS flow tracking in this case. Like the semi-automatic code, it needs to be made more configurable at some point...
@openshift/sig-networking PTAL