Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix debug panic #20550

Merged
merged 2 commits into from
Aug 14, 2018
Merged

Fix debug panic #20550

merged 2 commits into from
Aug 14, 2018

Conversation

juanvallejo
Copy link
Contributor

@juanvallejo juanvallejo commented Aug 6, 2018 •
edited
Loading

Debug was creating and using kcmd.LogOptions without passing a "consumeRequest" func and a RESTClientGetter

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1612661

cc @deads2k @soltysh

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 6, 2018
@juanvallejo
Copy link
Contributor Author

/retest

@juanvallejo juanvallejo force-pushed the jvallejo/fix-debug-panic branch from 0f0f2bf to 55db6b5 Compare August 6, 2018 20:08
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 6, 2018
@juanvallejo juanvallejo force-pushed the jvallejo/fix-debug-panic branch from 55db6b5 to 82db1ef Compare August 6, 2018 20:25
deads2k
deads2k reviewed Aug 7, 2018
View reviewed changes
pkg/oc/cli/debug/debug.go Outdated

// podContainerRunning returns false until the named container has ContainerStatus running (at least once),
// and will return an error if the pod is deleted, runs to completion, or the container pod is not available.
func podContainerRunning(containerName string) watch.ConditionFunc {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these the same? oc/lib/conditions

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, moved this helper to the oc/lib/conditions package

@juanvallejo juanvallejo force-pushed the jvallejo/fix-debug-panic branch from 82db1ef to 0e8193e Compare August 7, 2018 19:24
@juanvallejo
Copy link
Contributor Author

/test extended_clusterup

@juanvallejo
Copy link
Contributor Author

/retest

@juanvallejo
Copy link
Contributor Author

/test gcp

juanvallejo
juanvallejo commented Aug 8, 2018
View reviewed changes
pkg/oc/cli/admin/diagnostics/diagnostics/cluster/app_create/app.go

// podContainerRunning returns false until the named container has ContainerStatus running (at least once),
// and will return an error if the pod is deleted, runs to completion, or the container pod is not available.
func podContainerRunning(containerName string) watch.ConditionFunc {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deads2k this is a copy of the helper under oc/lib/conditions. This diagnostics file deals with internalversions, and we'll be removing diagnostics soon anyway, so I figured we could leave this copy here until then

soltysh
soltysh approved these changes Aug 9, 2018
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@soltysh
Copy link
Contributor

soltysh commented Aug 9, 2018

/retest

@soltysh soltysh self-assigned this Aug 9, 2018
@juanvallejo
Copy link
Contributor Author

/test gcp

2 similar comments
@juanvallejo
Copy link
Contributor Author

/test gcp

@juanvallejo
Copy link
Contributor Author

/test gcp

soltysh
soltysh approved these changes Aug 13, 2018
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@soltysh
Copy link
Contributor

soltysh commented Aug 13, 2018

/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 13, 2018
@smarterclayton
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juanvallejo, smarterclayton, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2018
@juanvallejo
Copy link
Contributor Author

/retest

1 similar comment
@juanvallejo
Copy link
Contributor Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit fffca53 into openshift:master Aug 14, 2018
@juanvallejo juanvallejo deleted the jvallejo/fix-debug-panic branch August 14, 2018 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k deads2k left review comments

@soltysh soltysh soltysh approved these changes

@enj enj Awaiting requested review from enj

Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@juanvallejo @soltysh @smarterclayton @openshift-ci-robot @deads2k @openshift-merge-robot